Changeset 104788 in vbox for trunk/src

Timestamp:

May 27, 2024 10:20:07 AM (8 months ago)

Author:

vboxsync

Message:

VMM/tmTimerQueuesSanityChecks: Corrected free count check. bugref:10688

File:

• trunk/src/VBox/VMM/VMMAll/TMAll.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/TMAll.cpp

@@ -713 +713 @@
 # ifdef IN_RING3
                 /* Go thru all the timers and check that the active ones all are in the active lists. */
-                uint32_t idxTimer = pQueue->cTimersAlloc;
-                uint32_t cFree    = 0;
+                int const rcAllocLock = PDMCritSectRwTryEnterShared(pVM, &pQueue->AllocLock);
+                uint32_t  idxTimer    = pQueue->cTimersAlloc;
+                uint32_t  cFree       = 0;
                 while (idxTimer-- > 0)
                 {
@@ -779 +780 @@
                     }
                 }
-                Assert(cFree == pQueue->cTimersFree);
+                if (RT_SUCCESS(rcAllocLock))
+                {
+                    Assert(cFree == pQueue->cTimersFree);
+                    PDMCritSectRwLeaveShared(pVM, &pQueue->AllocLock);
+                }
+                else
+                    Assert(cFree >= pQueue->cTimersFree); /* Can be lower as the tmr3TimerCreate may run concurrent. */
+
 # endif /* IN_RING3 */