Changeset 104791 in vbox for trunk/src/VBox

Timestamp:

May 27, 2024 3:11:54 PM (6 months ago)

Author:

vboxsync

Message:

Shared Clipboard: X11: Remove assertion when backing buffer is not big enough to store clipboard data, bugref:10698.

When X11 clipboard content needs to be copied from host/guest to the other side, default
buffer size (4K) initially will be used for such transfer. If this buffer is not big enough,
OVERFLOW error code should be sent back and new buffer size should be specified as well. This
asertion prevented this, and sent just OVERFLOW error without specifying new buffer size. As
a result, buffer >4K could not be copied.

File:

• trunk/src/VBox/GuestHost/SharedClipboard/clipboard-x11.cpp (modified) (1 diff)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-x11.cpp

@@ -2741 +2741 @@
                     PSHCLX11RESPONSE pResp = (PSHCLX11RESPONSE)pPayload->pvData;
                     AssertReturn(pResp->enmType == SHCLX11EVENTTYPE_READ, VERR_INVALID_PARAMETER);
-                    AssertReturn(pResp->Read.cbData <= cbMax, VERR_BUFFER_OVERFLOW); /* Paranoia. */
 
                     pPayload->pvData = NULL; /* pvData (pResp) is owned by ppResp now. */