Changeset 104851 in vbox for trunk/src/VBox/Main

Timestamp:

Jun 5, 2024 10:58:41 AM (8 months ago)

Author:

vboxsync

Message:

Main: Addressed @todos in IPlatformProperties::getSupportedVRAMRange(). bugref:​10693

File:

• trunk/src/VBox/Main/src-all/PlatformPropertiesImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-all/PlatformPropertiesImpl.cpp

@@ -856 +856 @@
             break;
 
-/** @todo r=bird: I think this is wrong.  The VMSVGA variant is the one that
- *        is trying to be the most compatible with the original HW (same PCI
- *        IDs etc). So, I don't see why we're subjecting VBoxSVGA to the SVGA
- *        limitations and the original VMSVGA variant to the VBox/VGA ones.
- *
- *        Other than the higher minimum values compared to VGA_VRAM_MIN,
- *        I'm not sure we need to care too much about restricting the MAX to
- *        128MB for either VMSVGA nor VBoxSVGA.  We should be using
- *        VGA_VRAM_MAX for all three. */
         case GraphicsControllerType_VBoxSVGA:
 #ifdef VBOX_WITH_VMSVGA
@@ -873 +864 @@
 # endif
                 cbMin = VBOX_SVGA_VRAM_MIN_SIZE;
-            cbMax = VBOX_SVGA_VRAM_MAX_SIZE;
+            /* We don't want to limit ourselves to VBOX_SVGA_VRAM_MAX_SIZE,
+             * so we use VGA_VRAM_MAX (as we do for VBoxVGA + VMSVGA) here as well. */
+            cbMax = VGA_VRAM_MAX;
             break;
 #else
@@ -893 +886 @@
     cbMax    = (ULONG)(RT_ALIGN_64(cbMax, cbStride) / _1M);
     cbStride = (ULONG)cbStride / _1M;
-
-    /** @todo r=bird: Why this? Why do these have to be powers of two?
-     * The algorithm could be better, use ASMBitLastSetU32 next time. */
-#define MAKE_POWER_OF_TWO(a_MB) \
-    while (!RT_IS_POWER_OF_TWO(a_MB)) \
-        a_MB = a_MB + 1; \
-
-    MAKE_POWER_OF_TWO(cbMin);
-    MAKE_POWER_OF_TWO(cbMax);
-    MAKE_POWER_OF_TWO(cbStride);
-
-#undef MAKE_POWER_OF_TWO
 
     /* Finally, clamp the values to our schema definitions before returning. */