Changeset 10486 in vbox

Timestamp:

Jul 10, 2008 8:59:15 PM (17 years ago)

Author:

vboxsync

Message:

cosmetics.

File:

• trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibMisc.cpp (modified) (4 diffs)

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibMisc.cpp

@@ -54 +54 @@
 VBGLR3DECL(int) VbglR3WriteLog(const char *pch, size_t cb)
 {
+#if defined(RT_OS_WINDOWS) /** @todo more OSes could take this route (solaris and freebsd for instance). */
+    /*
+     * Handle the entire request in one go.
+     */
+    return vbglR3DoIOCtl(VBOXGUEST_IOCTL_LOG(cb), (char *)pch, cb);
+
+#else
+    /*
+     * *BSD does not accept more than 4KB per ioctl request, while
+     * Linux can't express sizes above 8KB, so, split it up into 2KB chunks.
+     */
+# define STEP 2048
     int rc = VINF_SUCCESS;
-
-#if defined(RT_OS_WINDOWS)
-
-    rc = vbglR3DoIOCtl(VBOXGUEST_IOCTL_LOG(cb), (char *)pch, cb);
-#else
-
-    /*
-     * *BSD does not accept more than 4KB per ioctl request,
-     * so, split it up into 2KB chunks.
-     */
-#define STEP 2048
     for (size_t off = 0; off < cb && RT_SUCCESS(rc); off += STEP)
     {
@@ -71 +72 @@
         rc = vbglR3DoIOCtl(VBOXGUEST_IOCTL_LOG(cbStep), (char *)pch + off, cbStep);
     }
-#undef STEP
+# undef STEP
+    return rc;
 #endif
-    return rc;
 }
 
@@ -86 +87 @@
 VBGLR3DECL(int) VbglR3CtlFilterMask(uint32_t fOr, uint32_t fNot)
 {
+#if defined(RT_OS_WINDOWS)
+    /** @todo Not yet implemented. */
+    return VERR_NOT_SUPPORTED;
 
-#if defined(RT_OS_WINDOWS)
-
-    /* @todo Not yet implemented. */
-    return VINF_SUCCESS;
 #else
 
@@ -107 +107 @@
  * @param   fOr     Capabilities which have been added.
  * @param   fNot    Capabilities which have been removed.
+ *
+ * @todo    Move to a different file.
  */
 VBGLR3DECL(int) VbglR3SetGuestCaps(uint32_t fOr, uint32_t fNot)