Changeset 105009 in vbox

Timestamp:

Jun 24, 2024 5:57:54 PM (5 months ago)

Author:

vboxsync

Message:

Video Recording: Big revamp to improve overall performance. We now don't rely on the periodic display refresh callback anymore to render the entire framebuffer but now rely on delta updates ("dirty rectangles"). Also, we now only encode new frames when an area has changed. This also needed cursor position + change change notifications, as we render the cursor on the host side if mouse integration is enabled (requires 7.1 Guest Additions as of now). Optimized the BGRA32->YUV IV420 color space conversion as well as the overall amount of pixel data shuffled forth and back. Added a new testcase for the cropping/centering code [build fixes]. bugref:10650

Location:

trunk/src/VBox/Main/src-client

Files:

• DisplayImpl.cpp (modified) (4 diffs)
• RecordingInternals.cpp (modified) (1 diff)
• RecordingUtils.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -913 +913 @@
                 RECORDINGVIDEOFRAME Frame =
                 {
-                    (uint16_t)w, (uint16_t)h,
-                    (uint8_t )pFBInfo->u16BitsPerPixel, RECORDINGPIXELFMT_BRGA32, pFBInfo->u32LineSize,
+                    { (uint32_t)w, (uint32_t)h,
+                      (uint8_t )pFBInfo->u16BitsPerPixel, RECORDINGPIXELFMT_BRGA32, pFBInfo->u32LineSize },
                     pFBInfo->pu8FramebufferVRAM + (y * pFBInfo->u32LineSize + x * (pFBInfo->u16BitsPerPixel / 8)),
                     pFBInfo->w * pFBInfo->u32LineSize,
-                    (uint16_t)x, (uint16_t)y
+                    { (uint32_t)x, (uint32_t)y }
                 };
                 i_recordingScreenUpdate(uScreenId, &Frame);
@@ -958 +958 @@
                             RECORDINGVIDEOFRAME Frame =
                             {
-                                (uint16_t)ulWidth, (uint16_t)ulHeight,
-                                (uint8_t )ulBitsPerPixel, RECORDINGPIXELFMT_BRGA32, ulBytesPerLine,
+                                { (uint32_t)ulWidth, (uint32_t)ulHeight,
+                                  (uint8_t )ulBitsPerPixel, RECORDINGPIXELFMT_BRGA32, ulBytesPerLine },
                                 pAddress, ulHeight * ulBytesPerLine,
-                                0, 0
+                                { 0, 0 }
                             };
 
@@ -1018 +1018 @@
                         RECORDINGVIDEOFRAME Frame =
                         {
-                            (uint16_t)w, (uint16_t)h,
-                            (uint8_t)ulBitsPerPixel, RECORDINGPIXELFMT_BRGA32, ulBytesPerLine,
+                            { (uint32_t)w, (uint32_t)h,
+                              (uint8_t)ulBitsPerPixel, RECORDINGPIXELFMT_BRGA32, ulBytesPerLine },
                             pu8Dst, h * ulBytesPerLine,
-                            (uint16_t)x, (uint16_t)y
+                            { (uint32_t)x, (uint32_t)y }
                         };
 
@@ -2282 +2282 @@
             RECORDINGVIDEOFRAME Frame =
             {
-                (uint16_t)pFBInfo->w, (uint16_t)pFBInfo->h,
-                (uint8_t)pFBInfo->u16BitsPerPixel, RECORDINGPIXELFMT_BRGA32, pFBInfo->u32LineSize, //pFBInfo->w * (pFBInfo->u16BitsPerPixel / 8),
-                pFBInfo->pu8FramebufferVRAM, pFBInfo->h * pFBInfo->u32LineSize, 0, 0
+                { (uint32_t)pFBInfo->w, (uint32_t)pFBInfo->h,
+                  (uint8_t)pFBInfo->u16BitsPerPixel, RECORDINGPIXELFMT_BRGA32, pFBInfo->u32LineSize },
+                pFBInfo->pu8FramebufferVRAM, pFBInfo->h * pFBInfo->u32LineSize,
+                { 0, 0 }
             };
 

trunk/src/VBox/Main/src-client/RecordingInternals.cpp

@@ -37 +37 @@
 # include <iprt/formats/bmp.h>
 #endif
-
-#include "../src-client/Remotery.h"
 
 

trunk/src/VBox/Main/src-client/RecordingUtils.cpp

@@ -436 +436 @@
 
         /* Bitmaps (DIBs) are stored upside-down (thanks, OS/2), so work from the bottom up. */
-        uint32_t offSrc = cbRGBBuf - uBytesPerLine;
+        size_t offSrc = cbRGBBuf - uBytesPerLine;
 
         /* Do the copy. */