Changeset 105010 in vbox for trunk/src/VBox/Main

Timestamp:

Jun 24, 2024 6:47:56 PM (8 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

163628

Message:

Video Recording: Big revamp to improve overall performance. We now don't rely on the periodic display refresh callback anymore to render the entire framebuffer but now rely on delta updates ("dirty rectangles"). Also, we now only encode new frames when an area has changed. This also needed cursor position + change change notifications, as we render the cursor on the host side if mouse integration is enabled (requires 7.1 Guest Additions as of now). Optimized the BGRA32->YUV IV420 color space conversion as well as the overall amount of pixel data shuffled forth and back. Added a new testcase for the cropping/centering code [build fixes]. bugref:10650

Location:

trunk/src/VBox/Main/src-client

Files:

• MouseImpl.cpp (modified) (1 diff)
• Recording.cpp (modified) (2 diffs)
• RecordingInternals.cpp (modified) (1 diff)
• RecordingUtils.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/MouseImpl.cpp

@@ -241 +241 @@
 {
     RT_ZERO(mpDrv);
-    RT_ZERO(mPointerData);
     mcLastX = 0x8000;
     mcLastY = 0x8000;

trunk/src/VBox/Main/src-client/Recording.cpp

@@ -387 +387 @@
     switch (enmType)
     {
+#ifdef VBOX_WITH_AUDIO_RECORDING
         case RECORDINGFRAME_TYPE_AUDIO:
         {
@@ -400 +401 @@
             break;
         }
-
+#endif
         default:
             AssertFailed();
             break;
     }
+
+    if (!pFrame)
+        return VINF_SUCCESS;
 
     lock();

trunk/src/VBox/Main/src-client/RecordingInternals.cpp

@@ -231 +231 @@
  *
  * @returns VBox status code.
- * @param   pFrame              Destination frame.
+ * @param   pu8Dst              Destination buffer.
+ * @param   cbDst               Size (in bytes) of \a pu8Dst.
  * @param   uDstX               X destination (in pixel) within destination frame.
  * @param   uDstY               Y destination (in pixel) within destination frame.

trunk/src/VBox/Main/src-client/RecordingUtils.cpp

@@ -415 +415 @@
     if (!pszPath)
     {
-        int rc2 = RTPathTemp(szPath, sizeof(szPath));
-        if (RT_FAILURE(rc2))
-            return rc2;
+        int vrc2 = RTPathTemp(szPath, sizeof(szPath));
+        if (RT_FAILURE(vrc2))
+            return vrc2;
     }