Changeset 105065 in vbox

Timestamp:

Jun 27, 2024 5:26:43 PM (7 months ago)

Author:

vboxsync

Message:

Video Recording/Main: Fixed (release) logging when recording is disabled. bugref:10650

File:

• trunk/src/VBox/Main/src-client/DisplayImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -135 +135 @@
 
     for (unsigned i = 0; i < RT_ELEMENTS(maRecordingEnabled); i++)
-        maRecordingEnabled[i] = true;
+        maRecordingEnabled[i] = false;
 #endif
 
@@ -2305 +2305 @@
 int Display::i_recordingScreenUpdate(unsigned uScreenId, PRECORDINGVIDEOFRAME pFrame)
 {
-    if (!maRecordingEnabled[uScreenId])
-        return VINF_NO_CHANGE;
-
-    AssertPtr(mParent);
+    if (   uScreenId >= mcMonitors /* Might be SVGA_ID_INVALID. */
+        || !maRecordingEnabled[uScreenId])
+        return VINF_SUCCESS;
+
     RecordingContext *pCtx = mParent->i_recordingGetContext();
     if (!pCtx)
@@ -2353 +2353 @@
     RT_NOREF(fFlags);
 
-#if 0 /** @todo For whatever reason we always report SVGA_ID_INVALID here. Needs investigation. */
-    if (   uScreenId > mcMonitors /* Might be SVGA_ID_INVALID. */
+    if (   uScreenId >= mcMonitors /* Might be SVGA_ID_INVALID. */
         || !maRecordingEnabled[uScreenId])
         return VINF_SUCCESS;
-#endif
-
-    AssertPtr(mParent);
+
     RecordingContext *pCtx = mParent->i_recordingGetContext();
     if (!pCtx)