Changeset 10523 in vbox for trunk/src/VBox

Timestamp:

Jul 11, 2008 1:17:02 PM (16 years ago)

Author:

vboxsync

Message:

Backed out CPL change; fixes ACP2 installation regression for VT-x.

File:

• trunk/src/VBox/VMM/VMMAll/CPUMAllRegs.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/CPUMAllRegs.cpp

@@ -1818 +1818 @@
     uint32_t cpl;
 
-    /*
-     * The hidden CS.DPL register is always equal to the CPL, it is
-     * not affected by loading a conforming coding segment.
-     */
     if (CPUMAreHiddenSelRegsValid(pVM))
-        cpl = pCtxCore->csHid.Attr.n.u2Dpl;
+    {
+        /*
+         * The hidden CS.DPL register is always equal to the CPL, it is
+         * not affected by loading a conforming coding segment.
+         *
+         * This only seems to apply to AMD-V; in the VT-x case we *do* need to look at SS. (ACP2 regression during install after a far call to ring 2)
+         */
+        cpl = pCtxCore->ssHid.Attr.n.u2Dpl;
+    }
     else if (RT_LIKELY(pVM->cpum.s.Guest.cr0 & X86_CR0_PE))
     {