Changeset 105259 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jul 10, 2024 2:00:00 PM (6 months ago)

Author:

vboxsync

Message:

FE/Qt: NLS stuff: Reworking how we representing 3D acceleration feature being enabled; No more other display accelerations in any case.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIDetailsGenerator.cpp (modified) (2 diffs)
• snapshots/UISnapshotDetailsWidget.cpp (modified) (2 diffs)
• snapshots/UISnapshotDetailsWidget.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIDetailsGenerator.cpp

@@ -500 +500 @@
     }
 
-    /* Acceleration: */
+    /* 3D acceleration: */
     if (fOptions & UIExtraDataMetaDefs::DetailsElementOptionTypeDisplay_Acceleration)
     {
-        QStringList acceleration;
-        /* 3D acceleration: */
         if (comGraphics.GetAccelerate3DEnabled())
-            acceleration << QApplication::translate("UIDetails", "3D", "details (display)");
-        if (!acceleration.isEmpty())
-            table << UITextTableLine(QApplication::translate("UIDetails", "Acceleration", "details (display)"),
-                                     acceleration.join(", "));
+            table << UITextTableLine(QApplication::translate("UIDetails", "3D Acceleration", "details (display)"),
+                                     QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)"));
     }
 
@@ -1461 +1457 @@
     fAcceleration3D = comGraphics.GetAccelerate3DEnabled();
     if (fAcceleration3D)
-    {
-        const QString strAcceleration3D = fAcceleration3D
-            ? QApplication::translate("UICommon", "Enabled", "details report (3D Acceleration)")
-            : QApplication::translate("UICommon", "Disabled", "details report (3D Acceleration)");
         strInfo += e_strTableRow2
-            .arg(QApplication::translate("UIIndicatorDisplay", "3D acceleration"), strAcceleration3D);
-    }
+            .arg(QApplication::translate("UIDetails", "3D Acceleration", "details (display)"),
+                 QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)"));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/snapshots/UISnapshotDetailsWidget.cpp

@@ -1488 +1488 @@
 
             /* Acceleration? */
-            const QString strAcceleration = displayAccelerationReport(comGraphics);
-            const QString strAccelerationOld = displayAccelerationReport(comGraphicsOld);
-            if (!strAcceleration.isNull())
-            {
-                ++iRowCount;
-                strItem += QString(sSectionItemTpl2).arg(QApplication::translate("UIDetails", "Acceleration", "details (display)"),
-                                                         empReport(strAcceleration, strAccelerationOld));
+            const QString str3DAccelerationStatus = comGraphics.GetAccelerate3DEnabled()
+                                                  ? QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)")
+                                                  : QString();
+            const QString str3DAccelerationStatusOld = comGraphicsOld.GetAccelerate3DEnabled()
+                                                     ? QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)")
+                                                     : QString();
+            if (!str3DAccelerationStatus.isNull())
+            {
+                ++iRowCount;
+                strItem += QString(sSectionItemTpl2).arg(QApplication::translate("UIDetails", "3D Acceleration", "details (display)"),
+                                                         empReport(str3DAccelerationStatus, str3DAccelerationStatusOld));
             }
 
@@ -1874 +1878 @@
     /* Return report: */
     return dReport;
-}
-
-/* static */
-QString UISnapshotDetailsWidget::displayAccelerationReport(CGraphicsAdapter comGraphics)
-{
-    /* Prepare report: */
-    QStringList aReport;
-    /* 3D Acceleration? */
-    if (comGraphics.GetAccelerate3DEnabled())
-        aReport << QApplication::translate("UIDetails", "3D", "details (display)");
-    /* Compose and return report: */
-    return aReport.isEmpty() ? QString() : aReport.join(", ");
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/snapshots/UISnapshotDetailsWidget.h

@@ -184 +184 @@
     /** Acquires @a comMachine scale-factor report. */
     static double scaleFactorReport(CMachine comMachine);
-    /** Acquires @a comMachine display acceleration report. */
-    static QString displayAccelerationReport(CGraphicsAdapter comGraphics);
     /** Acquires @a comMachine VRDE server report. */
     static QStringList vrdeServerReport(CMachine comMachine);