Changeset 105267 in vbox

Timestamp:

Jul 11, 2024 7:58:35 AM (5 months ago)

Author:

vboxsync

Message:

Recording: Implemented support for a dedicated progress object, which is exposed to API clients. This can be used for better tracking the recording progress as well as for error reporting. The RecordingSettings API also now has a dedicated start() method to start recording, as well as support for attaching to an already ongoing recording by retrieving the progress object at a later time. Adapted FE/Qt (draft, see @todos), FE/VBoxManage and the Validation Kit testdriver to the new APIs. VBoxManage also can attach to an ongoing recording now. The recording progress object also will have multiple operations to get the recording progress for convenience [build fix]. bugref:10718

Location:

trunk/src/VBox/Main/src-client

Files:

• Recording.cpp (modified) (3 diffs)
• SessionImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-client/Recording.cpp

@@ -244 +244 @@
      * If one screen is configured to be recorded indefinitely (until manually stopped),
      * the operation count gets reset to 1. */
-    ULONG cOperations;
+    ULONG cOperations = 1; /* Always start at 1. */
     settings::RecordingScreenSettingsMap::const_iterator itScreen = Settings.mapScreens.begin();
     while (itScreen != Settings.mapScreens.end())
@@ -756 +756 @@
                                      ComPtr<IProgress> &pProgress)
 {
+    int vrc = VINF_SUCCESS;
+
     /* Copy the settings to our context. */
     m_Settings = Settings;
@@ -766 +768 @@
     settings::RecordingScreenSettings const &screen0Settings = itScreen0->second;
 
-    int vrc = this->audioInit(screen0Settings);
+    vrc = this->audioInit(screen0Settings);
     if (RT_FAILURE(vrc))
         return vrc;

trunk/src/VBox/Main/src-client/SessionImpl.cpp

@@ -785 +785 @@
     return mConsole->i_onRecordingStateChange(aEnable, aProgress);
 #else
-    RT_NOREF(aEnable);
+    RT_NOREF(aEnable, aProgress);
     return S_OK;
 #endif
@@ -802 +802 @@
     return mConsole->i_onRecordingScreenStateChange(aEnable, aScreen);
 #else
-    RT_NOREF(aEnable);
+    RT_NOREF(aEnable, aScreen);
     return S_OK;
 #endif