Changeset 105461 in vbox for trunk

Timestamp:

Jul 24, 2024 8:29:52 AM (6 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10384: In new VM wizard, guess OS type Id from user-entered VM name only if OS type Id is supported.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIGuestOSType.cpp (modified) (1 diff)
• globals/UIGuestOSType.h (modified) (1 diff)
• wizards/newvm/UIWizardNewVMNameOSTypePage.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIGuestOSType.cpp

@@ -317 +317 @@
 }
 
+bool UIGuestOSTypeManager::isGuestOSTypeIDSupported(const QString &strTypeId) const
+{
+    return m_supportedGuestOSTypeIDs.contains(strTypeId);
+}
+
 QString UIGuestOSTypeManager::getFamilyId(const QString &strTypeId) const
 {

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIGuestOSType.h

@@ -231 +231 @@
                                          KPlatformArchitecture enmArch = KPlatformArchitecture_None) const;
 
+    /* Returns true if @p strTypeId is supported by the host. */
+    bool isGuestOSTypeIDSupported(const QString &strTypeId) const;
+
     /** Returns whether specified @a strOSTypeId is of DOS type. */
     static bool isDOSType(const QString &strOSTypeId);

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMNameOSTypePage.cpp

@@ -300 +300 @@
     for (size_t i = 0; i < RT_ELEMENTS(gs_OSTypePattern); ++i)
     {
-        if (strNewName.contains(gs_OSTypePattern[i].pattern))
+        if (   strNewName.contains(gs_OSTypePattern[i].pattern)
+            && gpGlobalSession->guestOSTypeManager().isGuestOSTypeIDSupported(gs_OSTypePattern[i].pcstId))
+        {
+
             return pNameAndSystemEditor->setGuestOSTypeByTypeId(gs_OSTypePattern[i].pcstId);
+        }
     }
     return false;