Changeset 10549 in vbox for trunk/src/VBox/Devices

Timestamp:

Jul 11, 2008 7:42:41 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

33240

Message:

Fixed two completely nutty SUPR0ObjRelease where the spinlock was acquired first. Fortunately these calls were in untrodden error paths.

File:

• trunk/src/VBox/Devices/Network/SrvIntNetR0.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Network/SrvIntNetR0.cpp

@@ -1205 +1205 @@
     AssertPtrReturn(pSession, VERR_INVALID_PARAMETER);
     AssertPtrReturn(pNetwork, VERR_INVALID_PARAMETER);
-    PINTNET         pIntNet = pNetwork->pIntNet;
-    RTSPINLOCKTMP   Tmp = RTSPINLOCKTMP_INITIALIZER;
-
-    RTSpinlockAcquire(pIntNet->Spinlock, &Tmp);
+
     int rc = SUPR0ObjRelease(pNetwork->pvObj, pSession);
-    RTSpinlockRelease(pIntNet->Spinlock, &Tmp);
     LogFlow(("intnetNetworkClose: return %Vrc\n", rc));
     return rc;
@@ -1346 +1342 @@
                             *ppNetwork = pCur;
                         else
-                        {
-                            RTSpinlockAcquire(pIntNet->Spinlock, &Tmp);
                             SUPR0ObjRelease(pCur->pvObj, pSession);
-                            RTSpinlockRelease(pIntNet->Spinlock, &Tmp);
-                        }
                     }
                 }