Changeset 105524 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Jul 26, 2024 3:23:34 PM (9 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164189

Message:

FE/Qt: bugref:10543: Name and OS Type editor: Some children can be enabled by two independent reasons and we want to actually enable them only by both.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors

Files:

• UINameAndSystemEditor.cpp (modified) (4 diffs)
• UINameAndSystemEditor.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UINameAndSystemEditor.cpp

@@ -111 +111 @@
         m_pLabelFamily->setEnabled(fEnabled);
     if (m_pLabelDistribution)
-        m_pLabelDistribution->setEnabled(fEnabled);
+        setEnabledByReason(m_pLabelDistribution, 1, fEnabled);
     if (m_pLabelType)
         m_pLabelType->setEnabled(fEnabled);
@@ -117 +117 @@
         m_pComboFamily->setEnabled(fEnabled);
     if (m_pComboDistribution)
-        m_pComboDistribution->setEnabled(fEnabled);
+        setEnabledByReason(m_pComboDistribution, 1, fEnabled);
     if (m_pComboType)
         m_pComboType->setEnabled(fEnabled);
@@ -689 +689 @@
                                                                        QStringList() << distribution(),
                                                                        enmArch);
-    m_pLabelDistribution->setEnabled(!distributions.isEmpty());
-    m_pComboDistribution->setEnabled(!distributions.isEmpty());
+    setEnabledByReason(m_pLabelDistribution, 2, !distributions.isEmpty());
+    setEnabledByReason(m_pComboDistribution, 2, !distributions.isEmpty());
 
     /* Block signals initially and clear the combo: */
@@ -830 +830 @@
     m_pComboType->setCurrentIndex(iChosenIndex != -1 ? iChosenIndex : 0);
 }
+
+void UINameAndSystemEditor::setEnabledByReason(QWidget *pWidget, uint uReason, bool fEnabled)
+{
+    /* Some widgets can be enabled by two independent reasons;
+     * and we want to actually enable them only by both. */
+
+    /* Make sure passed widget is valid: */
+    AssertPtrReturnVoid(pWidget);
+    /* Make sure uReason provided is equal to 1 or 2: */
+    AssertReturnVoid(uReason == 1 || uReason == 2);
+
+    /* Property template: */
+    QString strPropertyTemplate("enabledByReason_%1");
+
+    /* Update value for passed uReason: */
+    pWidget->setProperty(strPropertyTemplate.arg(uReason).toUtf8().constData(), fEnabled);
+
+    /* Make sure widget enabled only if requested by both reasons: */
+    const QVariant property1 = pWidget->property(strPropertyTemplate.arg(1).toUtf8().constData());
+    const QVariant property2 = pWidget->property(strPropertyTemplate.arg(2).toUtf8().constData());
+    const bool fEnabledByReason1 = !property1.isValid() || property1.toBool();
+    const bool fEnabledByReason2 = !property2.isValid() || property2.toBool();
+    pWidget->setEnabled(fEnabledByReason1 && fEnabledByReason2);
+}

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UINameAndSystemEditor.h

@@ -184 +184 @@
     /** Selects preferred type. */
     void selectPreferredType();
+
+    /** Defines whether @a pWidget @a fEnabled by reason @a uReason. */
+    static void setEnabledByReason(QWidget *pWidget, uint uReason, bool fEnabled);
 
     /** @name Arguments