Changeset 105576 in vbox

Timestamp:

Aug 2, 2024 12:58:21 PM (4 months ago)

Author:

vboxsync

Message:

Main/Display: Return VBOX_E_NOT_SUPPORTED when DevVGA returns VERR_NOT_SUPPORTED. This is typically because the screen size is 0x0, which is a valid config before the VM starts executing code, so the GUI needs to have a way to identify this in order to correctly ignore it.

Location:

trunk/src/VBox/Main

Files:

• idl/VirtualBox.xidl (modified) (1 diff)
• src-client/DisplayImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -21942 +21942 @@
             <link to="#takeScreenShotToArray" />.
         </note>
+        <result name="VBOX_E_NOT_SUPPORTED">
+          Current screen configuration does not support taking a screen shot
+          (typically because it is 0x0 in size).
+        </result>
       </desc>
       <param name="screenId" type="unsigned long" dir="in"/>

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -2039 +2039 @@
         }
     }
-    else if (vrc == VERR_TRY_AGAIN)
-        hrc = setErrorBoth(E_UNEXPECTED, vrc, tr("Screenshot is not available at this time"));
+    else if (vrc == VERR_NOT_SUPPORTED) /* zero screen size (or too large screen size for vram) */
+        hrc = setErrorBoth(VBOX_E_NOT_SUPPORTED, vrc, tr("Screenshot is not possible at this time"));
+    else if (vrc == VERR_TRY_AGAIN)     /* resizing while taking screenshot */
+        hrc = setErrorBoth(E_UNEXPECTED, vrc, tr("Screenshot is not possible at this time"));
     else if (RT_FAILURE(vrc))
         hrc = setErrorBoth(VBOX_E_VM_ERROR, vrc, tr("Could not take a screenshot (%Rrc)"), vrc);