Changeset 105600 in vbox for trunk/include

Timestamp:

Aug 6, 2024 9:39:44 AM (6 months ago)

Author:

vboxsync

Message:

VMM/ARM: Move the VBox ARMv8 platform descriptor from the end of the address space right after the UEFI region, bugref:10746

The original solution was to avoid as many hardcoded addresses as possible by placing the VBox region descriptor right at the end
of the guest physical address space. This turned out to be a bad idea because on M3 the host maximum physical address width and
guest maxmium physical address width differ so mapping the platform descriptor fails. Also saved states would not be portable if
a saved state is mvoed between systems with different physical address widths.
The solution is to move the platform descriptor right after the UEFI region and move the MMIO region, which grew from top to bottom
to start right after the base RAM region and grow upwards.

File:

• trunk/include/VBox/platforms/vbox-armv8.h (modified) (2 diffs)

trunk/include/VBox/platforms/vbox-armv8.h

@@ -62 +62 @@
     /** Size of the base RAM region in bytes. */
     uint64_t                    cbRamBase;
-    /** Offset to the beginning of the FDT backwards from the start of this descriptor, 0 if not available. */
-    uint64_t                    u64OffBackFdt;
+    /** Offset to the beginning of the FDT from the start of this descriptor, 0 if not available. */
+    int64_t                     i64OffFdt;
     /** Size of the FDT in bytes, 0 if not available. */
     uint64_t                    cbFdt;
-    /** Offset to the RDSP/XSDP table for ACPI backwards from the start of this descriptor, 0 if not available. */
-    uint64_t                    u64OffBackAcpiXsdp;
+    /** Offset to the RDSP/XSDP table for ACPI from the start of this descriptor, 0 if not available. */
+    int64_t                     i64OffAcpiXsdp;
     /** Size of the RDSP/XSDP table, 0 if not available. */
     uint64_t                    cbAcpiXsdp;
-    /** Offset backwards to the start of the UEFI ROM region from the start of this descriptor, 0 if not available (doesn't make much sense though). */
-    uint64_t                    u64OffBackUefiRom;
+    /** Offset to the start of the UEFI ROM region from the start of this descriptor, 0 if not available (doesn't make much sense though). */
+    int64_t                     i64OffUefiRom;
     /** Size if the UEFI ROM region in bytes, 0 if not available. */
     uint64_t                    cbUefiRom;
-    /** Offset backwards to the start of the MMIO region from the start of this descriptor, 0 if not available (doesn't make much sense though). */
-    uint64_t                    u64OffBackMmio;
+    /** Offset to the start of the MMIO region from the start of this descriptor, 0 if not available (doesn't make much sense though). */
+    int64_t                     i64OffMmio;
     /** Size of the MMIO region in bytes, 0 if not available. */
     uint64_t                    cbMmio;
-    /** Offset backwards to the start of the MMIO32 region from the start of this descriptor, 0 if not available. */
-    uint64_t                    u64OffBackMmio32;
+    /** Offset to the start of the MMIO32 region from the start of this descriptor, 0 if not available. */
+    int64_t                     i64OffMmio32;
     /** Size of the MMIO32 region in bytes, 0 if not available. */
     uint64_t                    cbMmio32;
@@ -94 +94 @@
 #define VBOXPLATFORMARMV8_VERSION 0x1
 
+/** Physical address of the VBox platform descriptor (128MiB). */
+#define VBOXPLATFORMARMV8_PHYS_ADDR UINT64_C(0x08000000)
+
 #endif /* !VBOX_INCLUDED_platforms_vbox_armv8_h */