Changeset 105607 in vbox

Timestamp:

Aug 6, 2024 2:28:06 PM (8 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164286

Message:

VMM/IEM: Optimized out the cbInstrBufTotal zapping in iemTlbInvalidateLargePageWorkerInner (code TLB only). bugref:10727

File:

• trunk/src/VBox/VMM/VMMAll/IEMAll.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAll.cpp

@@ -855 +855 @@
 
     /*
+     * Set cbInstrBufTotal to zero if GCPtrInstrBufPcTag is within any of the tag ranges.
+     * We make ASSUMPTIONS about IEMTLB_CALC_TAG_NO_REV here.
+     */
+    AssertCompile(IEMTLB_CALC_TAG_NO_REV((RTGCPTR)0x8731U << GUEST_PAGE_SHIFT) == 0x8731U);
+    if (   !a_fDataTlb
+        && GCPtrInstrBufPcTag - GCPtrTag < (a_f2MbLargePage ? 512U : 1024U))
+        pVCpu->iem.s.cbInstrBufTotal = 0;
+
+    /*
      * Combine TAG values with the TLB revisions.
      */
@@ -876 +885 @@
                                                      a_idxEvenIter, a_fDataTlb); \
                         pTlb->aEntries[a_idxEvenIter].uTag = 0; \
-                        if (!a_fDataTlb && GCPtrTag == GCPtrInstrBufPcTag) \
-                            pVCpu->iem.s.cbInstrBufTotal = 0; \
                     } \
                 } \
@@ -892 +899 @@
                                                      a_idxEvenIter + 1, a_fDataTlb); \
                         pTlb->aEntries[a_idxEvenIter + 1].uTag = 0; \
-                        if (!a_fDataTlb && GCPtrTag == GCPtrInstrBufPcTag) \
-                            pVCpu->iem.s.cbInstrBufTotal = 0; \
                     } \
                 } \