Changeset 105712 in vbox for trunk

Timestamp:

Aug 16, 2024 8:55:59 PM (5 months ago)

Author:

vboxsync

Message:

VMM/IEM: Kicked out some debug tracing code from iemPollTimers. bugref:10656

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllThrdRecompiler.cpp (modified) (7 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllThrdRecompiler.cpp

@@ -2944 +2944 @@
 #define IEM_TIMER_POLL_MAX_ITER         _512K
 
-
-DECL_FORCE_INLINE(uint32_t) iemPollTimersCalcDefaultCountdown(uint64_t cNsDelta)
+#ifdef IEM_WITH_ADAPTIVE_TIMER_POLLING
+/**
+ * Calculates the number of TBs till the next timer polling using defaults.
+ *
+ * This is used when the previous run wasn't long enough to provide sufficient
+ * data and when comming back from the HALT state and we haven't actually
+ * executed anything for a while.
+ */
+DECL_FORCE_INLINE(uint32_t) iemPollTimersCalcDefaultCountdown(uint64_t cNsDelta) RT_NOEXCEPT
 {
     if (cNsDelta >= IEM_TIMER_POLL_MAX_NS)
@@ -2960 +2967 @@
     return IEM_TIMER_POLL_MIN_ITER;
 }
+#endif
 
 
@@ -3053 +3061 @@
             STAM_COUNTER_INC(&pVCpu->iem.s.StatTimerPollTiny);
             cItersTillNextPoll = IEM_TIMER_POLL_MIN_ITER;
-            IEMTLBTRACE_USER0(pVCpu, TMVirtualSyncGetLag(pVM), RT_MAKE_U64(cNsSinceLast, cNsDelta), cItersTillNextPoll, 0);
         }
         else
@@ -3059 +3066 @@
             uint32_t const cNsDeltaAdj   = cNsDelta >= IEM_TIMER_POLL_MAX_NS ? IEM_TIMER_POLL_MAX_NS     : (uint32_t)cNsDelta;
             uint32_t const cNsDeltaSlack = cNsDelta >= IEM_TIMER_POLL_MAX_NS ? IEM_TIMER_POLL_MAX_NS / 2 : cNsDeltaAdj / 4;
-            if (   cNsSinceLast            < RT_MAX(IEM_TIMER_POLL_MIN_NS, 64)
+            if (   cNsSinceLast       < RT_MAX(IEM_TIMER_POLL_MIN_NS, 64)
                 || cItersTillNextPoll < IEM_TIMER_POLL_MIN_ITER /* paranoia */)
             {
                 STAM_COUNTER_INC(&pVCpu->iem.s.StatTimerPollDefaultCalc);
                 cItersTillNextPoll = iemPollTimersCalcDefaultCountdown(cNsDeltaAdj);
-                IEMTLBTRACE_USER1(pVCpu, TMVirtualSyncGetLag(pVM), RT_MAKE_U64(cNsSinceLast, cNsDelta), cItersTillNextPoll, 3);
             }
             else if (   cNsSinceLast >= cNsDeltaAdj + cNsDeltaSlack
@@ -3074 +3080 @@
                     cItersTillNextPoll = cNsDeltaAdj / uFactor;
                     STAM_PROFILE_ADD_PERIOD(&pVCpu->iem.s.StatTimerPollFactorDivision, uFactor);
-                    IEMTLBTRACE_USER1(pVCpu, TMVirtualSyncGetLag(pVM), RT_MAKE_U64(cNsSinceLast, cNsDelta), cItersTillNextPoll, 1);
                 }
                 else
@@ -3081 +3086 @@
                     cItersTillNextPoll = cNsDeltaAdj * uFactor;
                     STAM_PROFILE_ADD_PERIOD(&pVCpu->iem.s.StatTimerPollFactorMultiplication, uFactor);
-                    IEMTLBTRACE_USER1(pVCpu, TMVirtualSyncGetLag(pVM), RT_MAKE_U64(cNsSinceLast, cNsDelta), cItersTillNextPoll, 2);
                 }
 
@@ -3098 +3102 @@
             }
             else
-            {
                 STAM_COUNTER_INC(&pVCpu->iem.s.StatTimerPollUnchanged);
-                IEMTLBTRACE_USER3(pVCpu, TMVirtualSyncGetLag(pVM), RT_MAKE_U64(cNsSinceLast, cNsDelta), cItersTillNextPoll, 0x00);
-            }
         }
         pVCpu->iem.s.cTbsTillNextTimerPollPrev = cItersTillNextPoll;