Changeset 105741 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Aug 20, 2024 6:17:15 PM (8 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164450

Message:

FE/Qt: Machine settings / System page: Make sure boot-order table is enabled only if EFI is disabled; Boot-order table is used for BIOS firmware only after all.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine

Files:

• UIMachineSettingsSystem.cpp (modified) (4 diffs)
• UIMachineSettingsSystem.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2008-2023 Oracle and/or its affiliates.
+ * Copyright (C) 2008-2024 Oracle and/or its affiliates.
  *
  * This file is part of VirtualBox base platform packages, as
@@ -622 +622 @@
 }
 
+void UIMachineSettingsSystem::sltHandleFirmwareTypeChanged()
+{
+    /// @todo move all the System page editors to new encapsulated UISystemSettingsEditor class,
+    ///       cause we are hiding logic in separate editors, not pages, this is the 1st bit of logic.
+    m_pEditorBootOrder->setEnabled(!m_pEditorMotherboardFeatures->isEnabledEfi());
+}
+
 void UIMachineSettingsSystem::handleFilterChange()
 {
@@ -657 +664 @@
     m_pEditorPointingHID->setEnabled(isMachineOffline());
     m_pEditorMotherboardFeatures->setEnabled(isMachineOffline());
+    sltHandleFirmwareTypeChanged();
 
     /* Polish 'Processor' availability: */
@@ -890 +898 @@
     connect(m_pEditorMotherboardFeatures, &UIMotherboardFeaturesEditor::sigChangedIoApic,
             this, &UIMachineSettingsSystem::revalidate);
+    connect(m_pEditorMotherboardFeatures, &UIMotherboardFeaturesEditor::sigChangedEfi,
+            this, &UIMachineSettingsSystem::sltHandleFirmwareTypeChanged);
 
     /* Configure 'Processor' connections: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.h

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2008-2023 Oracle and/or its affiliates.
+ * Copyright (C) 2008-2024 Oracle and/or its affiliates.
  *
  * This file is part of VirtualBox base platform packages, as
@@ -124 +124 @@
     virtual void sltRetranslateUI() RT_OVERRIDE RT_FINAL;
 
+    /** Handles firmware type change. */
+    void sltHandleFirmwareTypeChanged();
+
 private: