Changeset 105847 in vbox

Timestamp:

Aug 23, 2024 3:24:55 PM (7 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164566

Message:

FE/VBoxManage: Relaxed the default parameters of the "createvm" a bit by not making the platform type mandatory. Instead, rely on the guest OS' platform type if given, or use the host platform as the VM platform by default.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp

@@ -367 +367 @@
 
     /* check for required options */
-    if (platformArch == PlatformArchitecture_None)
-        return errorSyntax(Misc::tr("Parameter --platform-architecture is required"));
     if (bstrName.isEmpty())
         return errorSyntax(Misc::tr("Parameter --name is required"));
+
+    /* If the platform architecture is not specified explicitly ... */
+    if (platformArch == PlatformArchitecture_None)
+    {
+        /* ... determine it from the guest OS type, if given. */
+        if (bstrOsTypeId.isNotEmpty())
+        {
+            ComPtr<IGuestOSType> ptrGuestOsType;
+            a->virtualBox->GetGuestOSType(bstrOsTypeId.raw(), ptrGuestOsType.asOutParam());
+            if (ptrGuestOsType.isNull())
+                return RTMsgErrorExit(RTEXITCODE_FAILURE, Misc::tr("Unknown or invalid guest OS type given."));
+            CHECK_ERROR2I_RET(ptrGuestOsType, COMGETTER(PlatformArchitecture)(&platformArch), RTEXITCODE_FAILURE);
+        }
+        else /* use the host's platform type as the VM platform type. */
+        {
+            ComPtr<IHost> host;
+            CHECK_ERROR2I_RET(a->virtualBox, COMGETTER(Host)(host.asOutParam()), RTEXITCODE_FAILURE);
+            CHECK_ERROR2I_RET(host, COMGETTER(Architecture)(&platformArch), RTEXITCODE_FAILURE);
+        }
+    }
 
     do