Changeset 105864 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Aug 26, 2024 6:45:15 PM (6 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164584

Message:

Main: Added API for querying graphics features (2D Video / 3D Acceleration) of a specific graphics controller for a given platform and revamped the graphics controller attributes for 2D / 3D setters/getters to also use the new graphics features enumeration. Also, the system properties also now contain a dedicated API to query for graphics features (very basic for now, needs to be stuffed out). See SDK changelog for details. Added validation code when setting a specific graphics feature (which we never did before). bugref:10749

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIDetailsGenerator.cpp (modified) (2 diffs)
• runtime/UISession.cpp (modified) (1 diff)
• settings/editors/UIGraphicsControllerEditor.cpp (modified) (1 diff)
• settings/machine/UIMachineSettingsDisplay.cpp (modified) (2 diffs)
• snapshots/UISnapshotDetailsWidget.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIDetailsGenerator.cpp

@@ -500 +500 @@
     }
 
-    /* 3D acceleration: */
     if (fOptions & UIExtraDataMetaDefs::DetailsElementOptionTypeDisplay_Acceleration)
     {
-        if (comGraphics.GetAccelerate3DEnabled())
+        /* 3D acceleration: */
+        if (comGraphics.IsFeatureEnabled(KGraphicsFeature_Acceleration3D))
             table << UITextTableLine(QApplication::translate("UIDetails", "3D Acceleration", "details (display)"),
                                      QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)"));
@@ -1452 +1452 @@
 
     /* 3D acceleration: */
-    fAcceleration3D = comGraphics.GetAccelerate3DEnabled();
+    fAcceleration3D = comGraphics.IsFeatureEnabled(KGraphicsFeature_Acceleration3D);
     if (fAcceleration3D)
         strInfo += e_strTableRow2

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp

@@ -1605 +1605 @@
     else
     {
-        const BOOL fAccelerate3DEnabeld = comAdapter.GetAccelerate3DEnabled();
+        const BOOL fAccelerate3DEnabeld = comAdapter.IsFeatureEnabled(KGraphicsFeature_Acceleration3D);
         fSuccess = comAdapter.isOk();
         if (!fSuccess)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIGraphicsControllerEditor.cpp

@@ -164 +164 @@
                                             : KPlatformArchitecture_x86;
         CPlatformProperties comProperties = gpGlobalSession->virtualBox().GetPlatformProperties(enmArch);
-        m_supportedValues = comProperties.GetSupportedGraphicsControllerTypes();
+        m_supportedValues = comProperties.GetSupportedGfxControllerTypes();
 
         /* Make sure requested value if sane is present as well: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.cpp

@@ -397 +397 @@
         oldDisplayData.m_graphicsControllerType = comGraphics.GetGraphicsControllerType();
 #ifdef VBOX_WITH_3D_ACCELERATION
-        oldDisplayData.m_f3dAccelerationEnabled = comGraphics.GetAccelerate3DEnabled();
+        oldDisplayData.m_f3dAccelerationEnabled = comGraphics.IsFeatureEnabled(KGraphicsFeature_Acceleration3D);
 #endif
     }
@@ -1131 +1131 @@
             if (fSuccess && isMachineOffline() && newDisplayData.m_f3dAccelerationEnabled != oldDisplayData.m_f3dAccelerationEnabled)
             {
-                comGraphics.SetAccelerate3DEnabled(newDisplayData.m_f3dAccelerationEnabled);
+                comGraphics.SetFeature(KGraphicsFeature_Acceleration3D, newDisplayData.m_f3dAccelerationEnabled);
                 fSuccess = comGraphics.isOk();
             }
 #endif
-
             /* Get machine ID for further activities: */
             QUuid uMachineId;

trunk/src/VBox/Frontends/VirtualBox/src/snapshots/UISnapshotDetailsWidget.cpp

@@ -1488 +1488 @@
 
             /* Acceleration? */
-            const QString str3DAccelerationStatus = comGraphics.GetAccelerate3DEnabled()
-                                                  ? QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)")
-                                                  : QString();
-            const QString str3DAccelerationStatusOld = comGraphicsOld.GetAccelerate3DEnabled()
-                                                     ? QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)")
-                                                     : QString();
+            const QString str3DAccelerationStatus =   comGraphics.IsFeatureEnabled(KGraphicsFeature_Acceleration3D)
+                                                    ? QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)")
+                                                    : QString();
+            const QString str3DAccelerationStatusOld =   comGraphicsOld.IsFeatureEnabled(KGraphicsFeature_Acceleration3D)
+                                                       ? QApplication::translate("UIDetails", "Enabled", "details (display/3D Acceleration)")
+                                                       : QString();
             if (!str3DAccelerationStatus.isNull())
             {