Changeset 105864 in vbox for trunk/src/VBox/Main/src-all

Timestamp:

Aug 26, 2024 6:45:15 PM (9 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164584

Message:

Main: Added API for querying graphics features (2D Video / 3D Acceleration) of a specific graphics controller for a given platform and revamped the graphics controller attributes for 2D / 3D setters/getters to also use the new graphics features enumeration. Also, the system properties also now contain a dedicated API to query for graphics features (very basic for now, needs to be stuffed out). See SDK changelog for details. Added validation code when setting a specific graphics feature (which we never did before). bugref:10749

File:

• trunk/src/VBox/Main/src-all/PlatformPropertiesImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/src-all/PlatformPropertiesImpl.cpp

@@ -28 +28 @@
 #define LOG_GROUP LOG_GROUP_MAIN_PLATFORMPROPERTIES
 #include "PlatformPropertiesImpl.h"
+#include "GraphicsAdapterImpl.h" /* For static helper functions. */
 #include "VirtualBoxImpl.h"
 #include "LoggingNew.h"
@@ -40 +41 @@
 // generated header
 #include "SchemaDefs.h"
+
+
+// defines
+/////////////////////////////////////////////////////////////////////////////
+
+/** @def MY_VECTOR_ASSIGN_ARRAY
+ * Safe way to copy an array (static + const) into a vector w/ minimal typing.
+ *
+ * @param a_rVector     The destination vector reference.
+ * @param a_aSrcArray   The source array to assign to the vector.
+ */
+#if RT_GNUC_PREREQ(13, 0) && !RT_GNUC_PREREQ(14, 0) && defined(VBOX_WITH_GCC_SANITIZER)
+/* Workaround for g++ 13.2 incorrectly failing on arrays with a single entry in ASAN builds.
+   This is restricted to [13.0, 14.0), assuming the issue was introduced in the 13 cycle
+   and will be fixed by the time 14 is done.  If 14 doesn't fix it, extend the range
+   version by version till it is fixed. */
+# define MY_VECTOR_ASSIGN_ARRAY(a_rVector, a_aSrcArray) do { \
+        _Pragma("GCC diagnostic push") _Pragma("GCC diagnostic ignored \"-Wstringop-overread\""); \
+        (a_rVector).assign(&a_aSrcArray[0], &a_aSrcArray[RT_ELEMENTS(a_aSrcArray)]); \
+        _Pragma("GCC diagnostic pop"); \
+    } while (0)
+#else
+# define MY_VECTOR_ASSIGN_ARRAY(a_rVector, a_aSrcArray) do { \
+        (a_rVector).assign(&a_aSrcArray[0], &a_aSrcArray[RT_ELEMENTS(a_aSrcArray)]); \
+    } while (0)
+#endif
 
 
@@ -676 +703 @@
 }
 
-HRESULT PlatformProperties::getSupportedGraphicsControllerTypes(std::vector<GraphicsControllerType_T> &aSupportedGraphicsControllerTypes)
+HRESULT PlatformProperties::getSupportedGfxControllerTypes(std::vector<GraphicsControllerType_T> &aSupportedGraphicsControllerTypes)
 {
     switch (mPlatformArchitecture)
@@ -918 +945 @@
 }
 
+HRESULT PlatformProperties::getSupportedGfxFeaturesForType(GraphicsControllerType_T aGraphicsControllerType,
+                                                           std::vector<GraphicsFeature_T> &aSupportedGraphicsFeatures)
+{
+    int vrc = GraphicsAdapter::s_getSupportedFeatures(aGraphicsControllerType, aSupportedGraphicsFeatures);
+    if (RT_FAILURE(vrc))
+        return setError(E_INVALIDARG, tr("The graphics controller type (%d) is invalid"), aGraphicsControllerType);
+
+    return S_OK;
+}
+
 HRESULT PlatformProperties::getSupportedAudioControllerTypes(std::vector<AudioControllerType_T> &aSupportedAudioControllerTypes)
 {