Changeset 105865 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

Aug 26, 2024 8:37:09 PM (7 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164585

Message:

Main: Added API for querying graphics features (2D Video / 3D Acceleration) of a specific graphics controller for a given platform and revamped the graphics controller attributes for 2D / 3D setters/getters to also use the new graphics features enumeration. Also, the system properties also now contain a dedicated API to query for graphics features (very basic for now, needs to be stuffed out). See SDK changelog for details. Added validation code when setting a specific graphics feature (which we never did before) [build fix]. bugref:10749

File:

• trunk/src/VBox/Main/src-server/GraphicsAdapterImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/GraphicsAdapterImpl.cpp

@@ -279 +279 @@
 }
 
-/**
- * Static helper function to return all supported features for a given graphics controller.
- *
- * @returns VBox status code.
- * @param   enmController                          Graphics controller to return supported features for.
- * @param   vecSupportedGraphicsControllerFeatures Returned features on success.
- */
-/* static */
-int GraphicsAdapter::s_getSupportedFeatures(GraphicsControllerType_T enmController,
-                                            std::vector<GraphicsFeature_T> &vecSupportedGraphicsFeatures)
-{
-    switch (enmController)
-    {
-#ifdef VBOX_WITH_VMSVGA
-        case GraphicsControllerType_VBoxSVGA:
-        {
-            static const GraphicsFeature_T s_aGraphicsFeatures[] =
-            {
-# ifdef VBOX_WITH_VIDEOHWACCEL
-                GraphicsFeature_Acceleration2DVideo,
-# endif
-# ifdef VBOX_WITH_3D_ACCELERATION
-                GraphicsFeature_Acceleration3D
-# endif
-            };
-            MY_VECTOR_ASSIGN_ARRAY(vecSupportedGraphicsFeatures, s_aGraphicsFeatures);
-            break;
-        }
-#endif
-        case GraphicsControllerType_VBoxVGA:
-            RT_FALL_THROUGH();
-        case GraphicsControllerType_QemuRamFB:
-        {
-            static const GraphicsFeature_T s_aGraphicsFeatures[] =
-            {
-                GraphicsFeature_None
-            };
-            MY_VECTOR_ASSIGN_ARRAY(vecSupportedGraphicsFeatures, s_aGraphicsFeatures);
-            break;
-        }
-
-        default:
-            return VERR_INVALID_PARAMETER;
-    }
-
-    return VINF_SUCCESS;
-}
-
-/**
- * Static helper function to return whether a given graphics feature for a graphics controller is enabled or not.
- *
- * @returns \c true if the given feature is supported, or \c false if not.
- * @param   enmController           Graphics controlller to query a feature for.
- * @param   enmFeature              Feature to query.
- */
-/* static */
-bool GraphicsAdapter::s_isFeatureSupported(GraphicsControllerType_T enmController, GraphicsFeature_T enmFeature)
-{
-    std::vector<GraphicsFeature_T> vecSupportedGraphicsFeatures;
-    int vrc = GraphicsAdapter::s_getSupportedFeatures(enmController, vecSupportedGraphicsFeatures);
-    if (RT_SUCCESS(vrc))
-        return std::find(vecSupportedGraphicsFeatures.begin(),
-                         vecSupportedGraphicsFeatures.end(), enmFeature) != vecSupportedGraphicsFeatures.end();
-    return false;
-}
-
 HRESULT GraphicsAdapter::setFeature(GraphicsFeature_T aFeature, BOOL aEnabled)
 {
@@ -354 +288 @@
 
     /* Validate if the given feature is supported by this graphics controller. */
-    if (!GraphicsAdapter::s_isFeatureSupported(mData->graphicsControllerType, aFeature))
+    if (!PlatformProperties::s_isGraphicsControllerFeatureSupported(mData->graphicsControllerType, aFeature))
         return setError(VBOX_E_NOT_SUPPORTED, tr("The graphics controller does not support the given feature"));