Changeset 105879 in vbox for trunk/src/VBox

Timestamp:

Aug 28, 2024 12:04:09 AM (3 months ago)

Author:

vboxsync

Message:

Main/GraphicsAdapterImpl: Commented out #ifndef in isFeatureEnabled causing error messages on VM startup on arm. See todo for details. bugref:10749

File:

• trunk/src/VBox/Main/src-server/GraphicsAdapterImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/GraphicsAdapterImpl.cpp

@@ -305 +305 @@
     switch (aFeature)
     {
-#ifndef VBOX_WITH_VIRT_ARMV8 /* On macOS (ARM) we don't support any 2D/3D acceleration for now. */
+/// @todo r=bird: This '#ifndef causes 2+ error messages popping up on arm when
+/// starting a VM. I don't think VBOX_E_NOT_SUPPORTED is an appropiate
+/// answer to a simple question whether a feature is supported or not. Returning
+/// FALSE would be a lot more helpful in my opinion.
+//#ifndef VBOX_WITH_VIRT_ARMV8 /* On macOS (ARM) we don't support any 2D/3D acceleration for now. */
         case GraphicsFeature_Acceleration2DVideo:
             pfSetting = &mData->fAccelerate2DVideo;
@@ -314 +318 @@
             pfSetting = &mData->fAccelerate3D;
             break;
-#endif
+//#endif
         default:
             break;