Changeset 105885 in vbox for trunk/src/VBox

Timestamp:

Aug 28, 2024 10:55:08 AM (3 months ago)

Author:

vboxsync

Message:

Main: Better fix for GraphicsAdapter::isFeatureEnabled() if a feature is not supported; now it always returns S_OK but reports back FALSE. bugref:10749

File:

• trunk/src/VBox/Main/src-server/GraphicsAdapterImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/GraphicsAdapterImpl.cpp

@@ -305 +305 @@
     switch (aFeature)
     {
-/// @todo r=bird: This '#ifndef causes 2+ error messages popping up on arm when
-/// starting a VM. I don't think VBOX_E_NOT_SUPPORTED is an appropiate
-/// answer to a simple question whether a feature is supported or not. Returning
-/// FALSE would be a lot more helpful in my opinion.
-//#ifndef VBOX_WITH_VIRT_ARMV8 /* On macOS (ARM) we don't support any 2D/3D acceleration for now. */
+#ifndef VBOX_WITH_VIRT_ARMV8 /* On macOS (ARM) we don't support any 2D/3D acceleration for now. */
         case GraphicsFeature_Acceleration2DVideo:
             pfSetting = &mData->fAccelerate2DVideo;
@@ -318 +314 @@
             pfSetting = &mData->fAccelerate3D;
             break;
-//#endif
+#endif
         default:
             break;
     }
 
-    if (!pfSetting)
-        return VBOX_E_NOT_SUPPORTED;
-
-    *aEnabled = *pfSetting;
+    *aEnabled = pfSetting ? *pfSetting : FALSE;
 
     return S_OK;