Changeset 105971 in vbox for trunk/src/VBox/Main

Timestamp:

Sep 5, 2024 8:03:42 AM (8 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164711

Message:

Main: Removed IHost::acceleration3DAvailable property, as this wasn't really doing anything useful and just will confuse API users. We now have ISystemProperties::supportedGraphicsFeatures. bugref:10749

Location:

trunk/src/VBox/Main

Files:

• idl/VirtualBox.xidl (modified) (2 diffs)
• include/HostImpl.h (modified) (1 diff)
• src-server/HostImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -12383 +12383 @@
   <interface
     name="IHost" extends="$unknown"
-    uuid="89b05229-cecf-4ef6-816f-c0c13f2c4da3"
+    uuid="d5dcece0-b202-4416-a138-03502784cc07"
     wsmap="managed"
     rest="managed"
@@ -12566 +12566 @@
     <attribute name="UTCTime" type="long long" readonly="yes">
       <desc>Returns the current host time in milliseconds since 1970-01-01 UTC.</desc>
-    </attribute>
-
-    <attribute name="acceleration3DAvailable" type="boolean" readonly="yes">
-      <desc>Returns @c true when the host supports 3D hardware acceleration.</desc>
     </attribute>
 

trunk/src/VBox/Main/include/HostImpl.h

@@ -130 +130 @@
     HRESULT getOSVersion(com::Utf8Str &aOSVersion);
     HRESULT getUTCTime(LONG64 *aUTCTime);
-    HRESULT getAcceleration3DAvailable(BOOL *aAcceleration3DAvailable);
     HRESULT getVideoInputDevices(std::vector<ComPtr<IHostVideoInputDevice> > &aVideoInputDevices);
     HRESULT getUpdateHost(ComPtr<IUpdateAgent> &aUpdate);

trunk/src/VBox/Main/src-server/HostImpl.cpp

@@ -246 +246 @@
     /** @}  */
 
-    /** 3D hardware acceleration supported? Tristate, -1 meaning not probed. */
-    int                     f3DAccelerationSupported;
-
     HostPowerService        *pHostPowerService;
     /** Host's DNS information fetching */
@@ -456 +453 @@
         m->fRecheckVTSupported = false;
     }
-
-#ifdef VBOX_WITH_3D_ACCELERATION
-    /* Test for 3D hardware acceleration support later when (if ever) need. */
-    m->f3DAccelerationSupported = -1;
-#else
-    m->f3DAccelerationSupported = false;
-#endif
 
 #if defined(VBOX_WITH_HOSTNETIF_API) && (defined(RT_OS_LINUX) || defined(RT_OS_DARWIN) || defined(RT_OS_FREEBSD))
@@ -1471 +1461 @@
 
     return S_OK;
-}
-
-
-HRESULT Host::getAcceleration3DAvailable(BOOL *aSupported)
-{
-    HRESULT hrc = S_OK;
-    AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
-    if (m->f3DAccelerationSupported != -1)
-        *aSupported = m->f3DAccelerationSupported;
-    else
-    {
-        alock.release();
-
-#ifdef VBOX_WITH_3D_ACCELERATION
-        bool fSupported = true; // Test if Vulkan or DirectX is appropriately supported on the host
-#else
-        bool fSupported = false; /* shouldn't get here, but just in case. */
-#endif
-        AutoWriteLock alock2(this COMMA_LOCKVAL_SRC_POS);
-
-        m->f3DAccelerationSupported = fSupported;
-        alock2.release();
-        *aSupported = fSupported;
-    }
-
-#ifdef DEBUG_misha
-    AssertMsgFailed(("should not be here any more!\n"));
-#endif
-
-    return hrc;
 }