Changeset 10601 in vbox for trunk/src/VBox

Timestamp:

Jul 14, 2008 3:03:03 PM (16 years ago)

Author:

vboxsync

Message:

Fixed bogus return code check (string callback can fail if there's no handler!)

File:

• trunk/src/VBox/VMM/VMMAll/IOMAllMMIO.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/IOMAllMMIO.cpp

@@ -1495 +1495 @@
         const RTGCUINTREG cTransfersOrg = cTransfers;
         rc = IOMIOPortReadString(pVM, uPort, &GCPtrDst, &cTransfers, cbTransfer);
-        AssertRC(rc); Assert(cTransfers <= cTransfersOrg);
+        AssertRCReturn(rc, rc); 
+        Assert(cTransfers <= cTransfersOrg);
         pRegFrame->rdi += (cTransfersOrg - cTransfers) * cbTransfer;
     }
@@ -1503 +1504 @@
 #endif
 
-    while (cTransfers && rc == VINF_SUCCESS)
+    while (cTransfers)
     {
         uint32_t u32Value;
@@ -1656 +1657 @@
         const RTGCUINTREG cTransfersOrg = cTransfers;
         rc = IOMIOPortWriteString(pVM, uPort, &GCPtrSrc, &cTransfers, cbTransfer);
-        AssertRC(rc); Assert(cTransfers <= cTransfersOrg);
+        AssertRCReturn(rc, rc); 
+        Assert(cTransfers <= cTransfersOrg);
         pRegFrame->rsi += (cTransfersOrg - cTransfers) * cbTransfer;
     }
@@ -1664 +1666 @@
 #endif
 
-    while (cTransfers && rc == VINF_SUCCESS)
+    while (cTransfers)
     {
         uint32_t u32Value;