Changeset 106015 in vbox for trunk/src/VBox

Timestamp:

Sep 12, 2024 12:20:05 AM (3 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10513: Global Preferences / VM Settings: Make sure dialog layout is properly updated after serialization end which can change size-hints for numerous editors and can cause layout invalidation; Was able to reproduce it on different than English languages cause layout hints depends on NLS tag sizes.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• UIAdvancedSettingsDialog.cpp (modified) (2 diffs)
• UIAdvancedSettingsDialog.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp

@@ -779 +779 @@
     , m_pSerializeProcess(0)
     , m_fPolished(false)
+    , m_fFirstSerializationDone(false)
     , m_fSerializationIsInProgress(false)
     , m_fSerializationClean(false)
@@ -873 +874 @@
     /* Mark serialization finished: */
     m_fSerializationIsInProgress = false;
+
+    /* Finally make sure layouts freshly activated after
+     * all the pages loaded (as overall size-hint changed): */
+    foreach (QLayout *pLayout, findChildren<QLayout*>())
+        pLayout->activate();
+    /* Update scroll-area geometry finally: */
+    m_pScrollArea->updateGeometry();
+
+    /* For the 1st serialization we have some additional handling: */
+    if (!m_fFirstSerializationDone)
+    {
+        /* Which should be called just once: */
+        m_fFirstSerializationDone = true;
+
+        /* Make sure layout request processed before we resize widget to new size: */
+        QCoreApplication::sendPostedEvents(0, QEvent::LayoutRequest);
+        /* Resize to minimum size: */
+        resize(minimumSizeHint());
+        /* Explicit centering according to our parent: */
+        gpDesktop->centerWidget(this, parentWidget(), false);
+    }
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.h

@@ -238 +238 @@
     /** Holds whether dialog is polished. */
     bool  m_fPolished;
+    /** Holds whether the first serialization is done. */
+    bool  m_fFirstSerializationDone;
     /** Holds whether the serialization is in progress. */
     bool  m_fSerializationIsInProgress;