Changeset 106037 in vbox for trunk/src/VBox/VMM/VMMAll/target-x86

Timestamp:

Sep 12, 2024 3:17:06 PM (5 months ago)

Author:

vboxsync

Message:

VMM/IEM: Quick liveness fix for iemOp_pmovmskb_Gd_Ux. bugref:10652 bugref:10270

File:

• trunk/src/VBox/VMM/VMMAll/target-x86/IEMAllN8veEmit-x86.h (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/target-x86/IEMAllN8veEmit-x86.h

@@ -2290 +2290 @@
 {
 #ifdef RT_ARCH_AMD64
-    uint8_t const idxRegDst = iemNativeRegAllocTmpForGuestReg(pReNative, &off, IEMNATIVEGSTREG_GPR(idxGstRegDst), kIemNativeGstRegUse_ForFullWrite);
-    uint8_t const idxSimdRegSrc = iemNativeSimdRegAllocTmpForGuestSimdReg(pReNative, &off, IEMNATIVEGSTSIMDREG_SIMD(idxSimdGstRegSrc),
-                                                                          kIemNativeGstSimdRegLdStSz_Low128, kIemNativeGstRegUse_ReadOnly);
+    uint8_t const idxRegDst = iemNativeRegAllocTmpForGuestReg(pReNative, &off, IEMNATIVEGSTREG_GPR(idxGstRegDst),
+                                                              kIemNativeGstRegUse_ForFullWrite);
+    uint8_t const idxSimdRegSrc = iemNativeSimdRegAllocTmpForGuestSimdReg(pReNative, &off,
+                                                                          IEMNATIVEGSTSIMDREG_SIMD(idxSimdGstRegSrc),
+                                                                          kIemNativeGstSimdRegLdStSz_Low128,
+                                                                          kIemNativeGstRegUse_ReadOnly);
     PIEMNATIVEINSTR const pCodeBuf = iemNativeInstrBufEnsure(pReNative, off, 5);
 
     pCodeBuf[off++] = X86_OP_PRF_SIZE_OP;
     if (idxRegDst >= 8 || idxSimdRegSrc >= 8)
-        pCodeBuf[off++] =   (idxSimdRegSrc >= 8 ? X86_OP_REX_B : 0)
-                          | (idxRegDst     >= 8 ? X86_OP_REX_R : 0);
+        pCodeBuf[off++] = (idxSimdRegSrc >= 8 ? X86_OP_REX_B : 0)
+                        | (idxRegDst     >= 8 ? X86_OP_REX_R : 0);
     pCodeBuf[off++] = 0x0f;
     pCodeBuf[off++] = 0xd7;
@@ -2305 +2308 @@
     iemNativeSimdRegFreeTmp(pReNative, idxSimdRegSrc);
     iemNativeRegFreeTmp(pReNative, idxRegDst);
-#elif defined(RT_ARCH_ARM64)
-    uint8_t const idxRegDst = iemNativeRegAllocTmpForGuestReg(pReNative, &off, IEMNATIVEGSTREG_GPR(idxGstRegDst), kIemNativeGstRegUse_ForFullWrite);
+
+#elif defined(RT_ARCH_ARM64)
+    uint8_t const idxRegDst = iemNativeRegAllocTmpForGuestReg(pReNative, &off, IEMNATIVEGSTREG_GPR(idxGstRegDst),
+                                                              kIemNativeGstRegUse_ForFullWrite);
     uint8_t const idxRegTmp = iemNativeRegAllocTmp(pReNative, &off);
-    uint8_t const idxSimdRegSrc = iemNativeSimdRegAllocTmpForGuestSimdReg(pReNative, &off, IEMNATIVEGSTSIMDREG_SIMD(idxSimdGstRegSrc),
-                                                                          kIemNativeGstSimdRegLdStSz_Low128, kIemNativeGstRegUse_Calculation);
+    uint8_t const idxSimdRegSrc = iemNativeSimdRegAllocTmpForGuestSimdReg(pReNative, &off,
+                                                                          IEMNATIVEGSTSIMDREG_SIMD(idxSimdGstRegSrc),
+                                                                          kIemNativeGstSimdRegLdStSz_Low128,
+                                                                          kIemNativeGstRegUse_Calculation);
     PIEMNATIVEINSTR const pCodeBuf = iemNativeInstrBufEnsure(pReNative, off, 7);
 
@@ -2316 +2323 @@
      * for different approaches as NEON doesn't has an instruction equivalent for pmovmskb, so we have to emulate that.
      *
-     * As there is no way around emulating the exact semantics of pmovmskb we will use the same algorithm as the sse2neon implementation because
-     * there we can get away with loading any constants and the base algorithm is only 4 NEON instructions (+ 3 for extracting the result to a general register).
+     * As there is no way around emulating the exact semantics of pmovmskb we will use the same algorithm
+     * as the sse2neon implementation because there we can get away with loading any constants and the
+     * base algorithm is only 4 NEON instructions (+ 3 for extracting the result to a general register).
      *
      * The following illustrates the algorithm:
@@ -2347 +2355 @@
     iemNativeRegFreeTmp(pReNative, idxRegTmp);
     iemNativeRegFreeTmp(pReNative, idxRegDst);
+
 #else
 # error "Port me"