Changeset 106038 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

Sep 12, 2024 3:34:59 PM (6 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164787

Message:

Main/Snapshot: Prevent stray <vmname>.nvram files from accumulating in
the 'Snapshots' directory when taking a snapshot of a VM which currently
uses BIOS but also has a <vmname>.nvram file present. The snapshot code
would include the file with the snapshot during IMachine::takeSnapshot()
since it was present in the VM directory but IMachine::deleteSnapshot()
would only delete it if the snapshot was of a VM using EFI. Fixed by
excluding the <vmname>.nvram file from the snapshot directory during
IMachine::takeSnapshot() if the VM uses BIOS.

File:

• trunk/src/VBox/Main/src-server/SnapshotImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

@@ -1923 +1923 @@
         Utf8Str strNVRAM = mNvramStore->i_getNonVolatileStorageFile();
         Utf8Str strNVRAMSnap = pSnapshotMachine->i_getSnapshotNVRAMFilename();
-        if (strNVRAM.isNotEmpty() && strNVRAMSnap.isNotEmpty() && RTFileExists(strNVRAM.c_str()))
+        if (   strNVRAM.isNotEmpty()
+            && strNVRAMSnap.isNotEmpty()
+            && RTFileExists(strNVRAM.c_str())
+            && mFirmwareSettings->i_getFirmwareType() != FirmwareType_BIOS)
         {
             Utf8Str strNVRAMSnapAbs;