Changeset 106079 in vbox

Timestamp:

Sep 18, 2024 12:17:40 PM (2 months ago)

Author:

vboxsync

Message:

FE/Qt: ​bugref:10765. Moving product key line edit next to other two to make layout simpler.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors

Files:

• UIHostnameDomainNameEditor.cpp (modified) (7 diffs)
• UIHostnameDomainNameEditor.h (modified) (3 diffs)
• UIWizardNewVMEditors.cpp (modified) (6 diffs)
• UIWizardNewVMEditors.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIHostnameDomainNameEditor.cpp

@@ -41 +41 @@
 #include "UIHostnameDomainNameEditor.h"
 #include "UITranslationEventListener.h"
+#include "UIWizardNewVM.h"
 
 /* Other VBox includes: */
@@ -50 +51 @@
     , m_pHostnameLineEdit(0)
     , m_pDomainNameLineEdit(0)
+    , m_pProductKeyLineEdit(0)
     , m_pHostnameLabel(0)
     , m_pDomainNameLabel(0)
+    , m_pProductKeyLabel(0)
     , m_pMainLayout(0)
 {
@@ -110 +113 @@
 }
 
-int UIHostnameDomainNameEditor::firstColumnWidth() const
-{
-    int iWidth = 0;
-    if (m_pHostnameLabel)
-        iWidth = qMax(iWidth, m_pHostnameLabel->minimumSizeHint().width());
-    if (m_pDomainNameLabel)
-        iWidth = qMax(iWidth, m_pDomainNameLabel->minimumSizeHint().width());
-    return iWidth;
-}
-
-void UIHostnameDomainNameEditor::setFirstColumnWidth(int iWidth)
-{
-    if (m_pMainLayout)
-        m_pMainLayout->setColumnMinimumWidth(0, iWidth);
-}
-
 void UIHostnameDomainNameEditor::sltRetranslateUI()
 {
@@ -136 +123 @@
     if (m_pDomainNameLineEdit)
         m_pDomainNameLineEdit->setToolTip(tr("Holds the domain name."));
+    if (m_pProductKeyLabel)
+        m_pProductKeyLabel->setText(UIWizardNewVM::tr("&Product Key:"));
+    if (m_pProductKeyLineEdit)
+        m_pProductKeyLineEdit->setToolTip(UIWizardNewVM::tr("Holds the product key."));
 }
 
@@ -167 +158 @@
     setLayout(m_pMainLayout);
     int iRow = 0;
+
+
+
+    addLineEdit(iRow, m_pProductKeyLabel, m_pProductKeyLineEdit, m_pMainLayout);
     addLineEdit(iRow, m_pHostnameLabel, m_pHostnameLineEdit, m_pMainLayout);
     addLineEdit(iRow, m_pDomainNameLabel, m_pDomainNameLineEdit, m_pMainLayout);
+
+    if (m_pProductKeyLineEdit)
+    {
+        m_pProductKeyLineEdit->setInputMask(">NNNNN-NNNNN-NNNNN-NNNNN-NNNNN;#");
+        m_pProductKeyLineEdit->setMinimumWidth(fontMetrics().horizontalAdvance("NNNNN-NNNNN-NNNNN-NNNNN-NNNNN"));
+    }
 
     /* Host name and domain should be strings of minimum length of 2 and composed of alpha numerics, '-', and '.'
@@ -179 +180 @@
     connect(m_pDomainNameLineEdit, &QILineEdit::textChanged,
             this, &UIHostnameDomainNameEditor::sltDomainChanged);
+    connect(m_pProductKeyLineEdit, &QILineEdit::textChanged,
+            this, &UIHostnameDomainNameEditor::sigProductKeyChanged);
 
     sltRetranslateUI();
@@ -202 +205 @@
     emit sigHostnameDomainNameChanged(hostnameDomainName(), isComplete());
 }
+
+void UIHostnameDomainNameEditor::disableEnableProductKeyWidgets(bool fEnabled)
+{
+    if (m_pProductKeyLabel)
+        m_pProductKeyLabel->setEnabled(fEnabled);
+    if (m_pProductKeyLineEdit)
+        m_pProductKeyLineEdit->setEnabled(fEnabled);
+}

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIHostnameDomainNameEditor.h

@@ -50 +50 @@
 
     void sigHostnameDomainNameChanged(const QString &strHostNameDomain, bool fIsComplete);
+    void sigProductKeyChanged(const QString &strProductKey);
 
 public:
@@ -66 +67 @@
     void mark();
 
-    int firstColumnWidth() const;
-    void setFirstColumnWidth(int iWidth);
+    void disableEnableProductKeyWidgets(bool fEnabled);
 
 private slots:
@@ -82 +82 @@
     QILineEdit *m_pHostnameLineEdit;
     QILineEdit *m_pDomainNameLineEdit;
+    QILineEdit *m_pProductKeyLineEdit;
 
     QLabel *m_pHostnameLabel;
     QLabel *m_pDomainNameLabel;
+    QLabel *m_pProductKeyLabel;
     QGridLayout *m_pMainLayout;
 };

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIWizardNewVMEditors.cpp

@@ -225 +225 @@
 UIAdditionalUnattendedOptions::UIAdditionalUnattendedOptions(QWidget *pParent /* = 0 */)
     : QGroupBox(pParent)
-    , m_pProductKeyLabel(0)
-    , m_pProductKeyLineEdit(0)
     , m_pHostnameDomainNameEditor(0)
     , m_pStartHeadlessCheckBox(0)
@@ -238 +236 @@
     m_pMainLayout->setColumnStretch(0, 0);
     m_pMainLayout->setColumnStretch(1, 1);
-    m_pProductKeyLabel = new QLabel;
-    if (m_pProductKeyLabel)
-    {
-        m_pProductKeyLabel->setAlignment(Qt::AlignRight);
-        m_pProductKeyLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
-        m_pMainLayout->addWidget(m_pProductKeyLabel, 0, 0);
-    }
-    m_pProductKeyLineEdit = new QILineEdit;
-    if (m_pProductKeyLineEdit)
-    {
-        m_pProductKeyLineEdit->setInputMask(">NNNNN-NNNNN-NNNNN-NNNNN-NNNNN;#");
-        if (m_pProductKeyLabel)
-            m_pProductKeyLabel->setBuddy(m_pProductKeyLineEdit);
-        m_pMainLayout->addWidget(m_pProductKeyLineEdit, 0, 1, 1, 2);
-    }
 
     m_pHostnameDomainNameEditor = new UIHostnameDomainNameEditor;
@@ -263 +246 @@
 
     if (m_pHostnameDomainNameEditor)
+    {
         connect(m_pHostnameDomainNameEditor, &UIHostnameDomainNameEditor::sigHostnameDomainNameChanged,
                 this, &UIAdditionalUnattendedOptions::sigHostnameDomainNameChanged);
-    if (m_pProductKeyLineEdit)
-        connect(m_pProductKeyLineEdit, &QILineEdit::textChanged,
+        connect(m_pHostnameDomainNameEditor, &UIHostnameDomainNameEditor::sigProductKeyChanged,
                 this, &UIAdditionalUnattendedOptions::sigProductKeyChanged);
+    }
     if (m_pStartHeadlessCheckBox)
         connect(m_pStartHeadlessCheckBox, &QCheckBox::toggled,
@@ -280 +264 @@
 {
     setTitle(UIWizardNewVM::tr("Additional Options"));
-
-    if (m_pProductKeyLabel)
-        m_pProductKeyLabel->setText(UIWizardNewVM::tr("&Product Key:"));
 
     if (m_pStartHeadlessCheckBox)
@@ -290 +271 @@
                                                                "unattended guest OS installation of newly created virtual machine."));
     }
-
-    int iMaxWidth = 0;
-    if (m_pProductKeyLabel)
-        iMaxWidth = qMax(m_pProductKeyLabel->minimumSizeHint().width(), iMaxWidth);
-    if (m_pHostnameDomainNameEditor)
-        iMaxWidth = qMax(m_pHostnameDomainNameEditor->firstColumnWidth(), iMaxWidth);
-    if (iMaxWidth > 0)
-    {
-        m_pMainLayout->setColumnMinimumWidth(0, iMaxWidth);
-        m_pHostnameDomainNameEditor->setFirstColumnWidth(iMaxWidth);
-    }
-    if (m_pProductKeyLineEdit)
-        m_pProductKeyLineEdit->setToolTip(UIWizardNewVM::tr("Holds the product key."));
 }
 
@@ -359 +327 @@
 void UIAdditionalUnattendedOptions::disableEnableProductKeyWidgets(bool fEnabled)
 {
-    if (m_pProductKeyLabel)
-        m_pProductKeyLabel->setEnabled(fEnabled);
-    if (m_pProductKeyLineEdit)
-        m_pProductKeyLineEdit->setEnabled(fEnabled);
+    if (m_pHostnameDomainNameEditor)
+        m_pHostnameDomainNameEditor->disableEnableProductKeyWidgets(fEnabled);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIWizardNewVMEditors.h

@@ -124 +124 @@
 
     void sigHostnameDomainNameChanged(const QString &strHostnameDomainName, bool fIsComplete);
-    void sigProductKeyChanged(const QString &strHostnameDomainName);
+    void sigProductKeyChanged(const QString &strProductKey);
     void sigStartHeadlessChanged(bool fChecked);
 
@@ -152 +152 @@
     void prepare();
 
-    QLabel *m_pProductKeyLabel;
-    QILineEdit *m_pProductKeyLineEdit;
+
+
     UIHostnameDomainNameEditor *m_pHostnameDomainNameEditor;
     QCheckBox *m_pStartHeadlessCheckBox;