Changeset 106097 in vbox for trunk

Timestamp:

Sep 19, 2024 2:27:50 PM (7 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164872

Message:

VMM/IEM: Liveness fix for MXCSR modifying in addps and friends. bugref:10652 bugref:10372

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllInstPython.py (modified) (1 diff)
• VMMAll/IEMAllInstTwoByte0f.cpp.h (modified) (2 diffs)
• VMMAll/IEMAllN8veLiveness.h (modified) (1 diff)
• VMMAll/IEMAllN8veRecompFuncs.h (modified) (1 diff)
• include/IEMMc.h (modified) (1 diff)
• testcase/tstIEMCheckMc.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllInstPython.py

@@ -3213 +3213 @@
     'IEM_MC_LIVENESS_XREG_CLOBBER':                              (McBlock.parseMcGeneric,           False, False, True,  ),
     'IEM_MC_LIVENESS_XREG_MODIFY':                               (McBlock.parseMcGeneric,           False, False, True,  ),
+    'IEM_MC_LIVENESS_MXCSR_INPUT':                               (McBlock.parseMcGeneric,           False, False, True,  ),
+    'IEM_MC_LIVENESS_MXCSR_CLOBBER':                             (McBlock.parseMcGeneric,           False, False, True,  ),
+    'IEM_MC_LIVENESS_MXCSR_MODIFY':                              (McBlock.parseMcGeneric,           False, False, True,  ),
     'IEM_MC_LOCAL':                                              (McBlock.parseMcLocal,             False, False, True,  ),
     'IEM_MC_LOCAL_ASSIGN':                                       (McBlock.parseMcLocalAssign,       False, False, True,  ),

trunk/src/VBox/VMM/VMMAll/IEMAllInstTwoByte0f.cpp.h

@@ -768 +768 @@
             IEM_MC_PREPARE_SSE_USAGE(); \
             IEM_MC_NATIVE_IF(a_fRegNativeArchs) { \
+                IEM_MC_LIVENESS_MXCSR_MODIFY(); \
                 IEM_MC_NATIVE_EMIT_2_EX(RT_CONCAT3(iemNativeEmit_,a_Ins,_rr_u128), IEM_GET_MODRM_REG(pVCpu, bRm), IEM_GET_MODRM_RM(pVCpu, bRm)); \
             } IEM_MC_NATIVE_ELSE() { \
@@ -796 +797 @@
             IEM_MC_PREPARE_SSE_USAGE(); \
             IEM_MC_NATIVE_IF(a_fRegNativeArchs) { \
+                IEM_MC_LIVENESS_MXCSR_MODIFY(); \
                 IEM_MC_NATIVE_EMIT_2_EX(RT_CONCAT3(iemNativeEmit_,a_Ins,_rv_u128), IEM_GET_MODRM_REG(pVCpu, bRm), uSrc2); \
             } IEM_MC_NATIVE_ELSE() { \

trunk/src/VBox/VMM/VMMAll/IEMAllN8veLiveness.h

@@ -1251 +1251 @@
 #define IEM_MC_LIVENESS_XREG_MODIFY(a_iXReg)            NOP()
 
+#define IEM_MC_LIVENESS_MXCSR_INPUT()                   IEM_LIVENESS_MXCSR_INPUT()
+#define IEM_MC_LIVENESS_MXCSR_CLOBBER()                 IEM_LIVENESS_MXCSR_CLOBBER()
+#define IEM_MC_LIVENESS_MXCSR_MODIFY()                  IEM_LIVENESS_MXCSR_MODIFY()
+

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompFuncs.h

@@ -266 +266 @@
 #define IEM_MC_LIVENESS_XREG_MODIFY(a_iXReg)    ((void)0)
 
+#define IEM_MC_LIVENESS_MXCSR_INPUT()           ((void)0)
+#define IEM_MC_LIVENESS_MXCSR_CLOBBER()         ((void)0)
+#define IEM_MC_LIVENESS_MXCSR_MODIFY()          ((void)0)
 
 

trunk/src/VBox/VMM/include/IEMMc.h

@@ -3332 +3332 @@
 #define IEM_MC_LIVENESS_XREG_MODIFY(a_iXReg)            ((void)0)
 
+/** Recompiler liveness info: input MXCSR */
+#define IEM_MC_LIVENESS_MXCSR_INPUT()                   ((void)0)
+/** Recompiler liveness info: clobbered MXCSR */
+#define IEM_MC_LIVENESS_MXCSR_CLOBBER()                 ((void)0)
+/** Recompiler liveness info: modified MXCSR (i.e. input & output)  */
+#define IEM_MC_LIVENESS_MXCSR_MODIFY()                  ((void)0)
+
 /** @todo add more as needed. */
 

trunk/src/VBox/VMM/testcase/tstIEMCheckMc.cpp

@@ -1164 +1164 @@
 #define IEM_MC_LIVENESS_XREG_MODIFY(a_iXReg)                            ((void)a_iXReg)
 
+#define IEM_MC_LIVENESS_MXCSR_INPUT()                                   ((void)0)
+#define IEM_MC_LIVENESS_MXCSR_CLOBBER()                                 ((void)0)
+#define IEM_MC_LIVENESS_MXCSR_MODIFY()                                  ((void)0)
+
 /** @}  */