Changeset 106179 in vbox for trunk/src/VBox/VMM/include

Timestamp:

Sep 29, 2024 1:14:19 AM (2 months ago)

Author:

vboxsync

Message:

VMM/IEM: Reworked the div, idiv, mul and imul assembly workers and how we raise division error exceptions. The latter is to simplify eflags management. bugref:10720

Location:

trunk/src/VBox/VMM/include

Files:

• IEMInternal.h (modified) (8 diffs)
• IEMMc.h (modified) (1 diff)

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -2366 +2366 @@
     /** Native recompiler: Number of times status flags calc has been skipped. */
     STAMCOUNTER             StatNativeEflSkippedArithmetic;
+    /** Native recompiler: Number of times status flags calc has been postponed. */
+    STAMCOUNTER             StatNativeEflPostponedArithmetic;
     /** Native recompiler: Total number instructions in this category. */
     STAMCOUNTER             StatNativeEflTotalArithmetic;
@@ -2371 +2373 @@
     /** Native recompiler: Number of times status flags calc has been skipped. */
     STAMCOUNTER             StatNativeEflSkippedLogical;
+    /** Native recompiler: Number of times status flags calc has been postponed. */
+    STAMCOUNTER             StatNativeEflPostponedLogical;
     /** Native recompiler: Total number instructions in this category. */
     STAMCOUNTER             StatNativeEflTotalLogical;
@@ -2376 +2380 @@
     /** Native recompiler: Number of times status flags calc has been skipped. */
     STAMCOUNTER             StatNativeEflSkippedShift;
+    /** Native recompiler: Number of times status flags calc has been postponed. */
+    STAMCOUNTER             StatNativeEflPostponedShift;
     /** Native recompiler: Total number instructions in this category. */
     STAMCOUNTER             StatNativeEflTotalShift;
@@ -2550 +2556 @@
 
 #ifdef IEM_WITH_TLB_TRACE
-    //uint64_t                au64Padding[0];
+    uint64_t                au64Padding[5];
 #else
-    uint64_t                au64Padding[2];
+    uint64_t                au64Padding[7];
 #endif
 
@@ -3538 +3544 @@
 /** @name Multiplication and division operations.
  * @{ */
-typedef IEM_DECL_IMPL_TYPE(int, FNIEMAIMPLMULDIVU8,(uint16_t *pu16AX, uint8_t u8FactorDivisor, uint32_t *pEFlags));
+typedef IEM_DECL_IMPL_TYPE(uint32_t, FNIEMAIMPLMULDIVU8,(uint16_t *pu16AX, uint8_t u8FactorDivisor, uint32_t fEFlags));
 typedef FNIEMAIMPLMULDIVU8  *PFNIEMAIMPLMULDIVU8;
 FNIEMAIMPLMULDIVU8 iemAImpl_mul_u8,  iemAImpl_mul_u8_amd,  iemAImpl_mul_u8_intel;
@@ -3545 +3551 @@
 FNIEMAIMPLMULDIVU8 iemAImpl_idiv_u8, iemAImpl_idiv_u8_amd, iemAImpl_idiv_u8_intel;
 
-typedef IEM_DECL_IMPL_TYPE(int, FNIEMAIMPLMULDIVU16,(uint16_t *pu16AX, uint16_t *pu16DX, uint16_t u16FactorDivisor, uint32_t *pEFlags));
+typedef IEM_DECL_IMPL_TYPE(uint32_t, FNIEMAIMPLMULDIVU16,(uint16_t *pu16AX, uint16_t *pu16DX, uint16_t u16FactorDivisor, uint32_t fEFlags));
 typedef FNIEMAIMPLMULDIVU16  *PFNIEMAIMPLMULDIVU16;
 FNIEMAIMPLMULDIVU16 iemAImpl_mul_u16,  iemAImpl_mul_u16_amd,  iemAImpl_mul_u16_intel;
@@ -3552 +3558 @@
 FNIEMAIMPLMULDIVU16 iemAImpl_idiv_u16, iemAImpl_idiv_u16_amd, iemAImpl_idiv_u16_intel;
 
-typedef IEM_DECL_IMPL_TYPE(int, FNIEMAIMPLMULDIVU32,(uint32_t *pu32EAX, uint32_t *pu32EDX, uint32_t u32FactorDivisor, uint32_t *pEFlags));
+typedef IEM_DECL_IMPL_TYPE(uint32_t, FNIEMAIMPLMULDIVU32,(uint32_t *pu32EAX, uint32_t *pu32EDX, uint32_t u32FactorDivisor, uint32_t fEFlags));
 typedef FNIEMAIMPLMULDIVU32  *PFNIEMAIMPLMULDIVU32;
 FNIEMAIMPLMULDIVU32 iemAImpl_mul_u32,  iemAImpl_mul_u32_amd,  iemAImpl_mul_u32_intel;
@@ -3559 +3565 @@
 FNIEMAIMPLMULDIVU32 iemAImpl_idiv_u32, iemAImpl_idiv_u32_amd, iemAImpl_idiv_u32_intel;
 
-typedef IEM_DECL_IMPL_TYPE(int, FNIEMAIMPLMULDIVU64,(uint64_t *pu64RAX, uint64_t *pu64RDX, uint64_t u64FactorDivisor, uint32_t *pEFlags));
+typedef IEM_DECL_IMPL_TYPE(uint32_t, FNIEMAIMPLMULDIVU64,(uint64_t *pu64RAX, uint64_t *pu64RDX, uint64_t u64FactorDivisor, uint32_t fEFlags));
 typedef FNIEMAIMPLMULDIVU64  *PFNIEMAIMPLMULDIVU64;
 FNIEMAIMPLMULDIVU64 iemAImpl_mul_u64,  iemAImpl_mul_u64_amd,  iemAImpl_mul_u64_intel;

trunk/src/VBox/VMM/include/IEMMc.h

@@ -109 +109 @@
 
 
-#define IEM_MC_RAISE_DIVIDE_ERROR()                     return iemRaiseDivideError(pVCpu)
+#define IEM_MC_RAISE_DIVIDE_ERROR_IF_LOCAL_IS_ZERO(a_uVar) \
+    do { \
+        if (RT_LIKELY((a_uVar) != 0)) \
+        { /* probable */ } \
+        else return iemRaiseDivideError(pVCpu); \
+    } while (0)
 #define IEM_MC_MAYBE_RAISE_DEVICE_NOT_AVAILABLE()       \
     do { \