Changeset 106206 in vbox for trunk/src/VBox

Timestamp:

Oct 2, 2024 12:13:37 PM (6 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

164990

Message:

FE/Qt: bugref:10784: VBox Manager / Details pane: A bit of cleanup for prepare/cleanup cascade; Simplifying the code.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/details

Files:

• UIDetailsModel.cpp (modified) (2 diffs)
• UIDetailsModel.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsModel.cpp

@@ -767 +767 @@
 void UIDetailsModel::prepare()
 {
-    /* Prepare things: */
-    prepareScene();
-    prepareRoot();
-    prepareContextMenu();
-    loadSettings();
-}
-
-void UIDetailsModel::prepareScene()
-{
+    /* Prepare scene: */
     m_pScene = new QGraphicsScene(this);
     if (m_pScene)
         m_pScene->installEventFilter(this);
-}
-
-void UIDetailsModel::prepareRoot()
-{
+
+    /* Prepare root item: */
     m_pRoot = new UIDetailsGroup(scene());
-}
-
-void UIDetailsModel::prepareContextMenu()
-{
+
+    /* Prepare context-menu: */
     m_pContextMenu = new UIDetailsContextMenu(this);
-}
-
-void UIDetailsModel::loadSettings()
-{
+
+    /* Load stuff: */
     loadDetailsCategories();
     loadDetailsOptions();
@@ -964 +950 @@
 }
 
-void UIDetailsModel::cleanupContextMenu()
-{
+void UIDetailsModel::cleanup()
+{
+    /* Cleanup context-menu: */
     delete m_pContextMenu;
     m_pContextMenu = 0;
-}
-
-void UIDetailsModel::cleanupRoot()
-{
+
+    /* Cleanup root item: */
     delete m_pRoot;
     m_pRoot = 0;
-}
-
-void UIDetailsModel::cleanupScene()
-{
+
+    /* Cleanup scene: */
     delete m_pScene;
     m_pScene = 0;
-}
-
-void UIDetailsModel::cleanup()
-{
-    /* Cleanup things: */
-    cleanupContextMenu();
-    cleanupRoot();
-    cleanupScene();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsModel.h

@@ -201 +201 @@
         /** Prepares all. */
         void prepare();
-        /** Prepares scene. */
-        void prepareScene();
-        /** Prepares root. */
-        void prepareRoot();
-        /** Prepares context-menu. */
-        void prepareContextMenu();
-        /** Loads settings. */
-        void loadSettings();
+
         /** Loads details categories. */
         void loadDetailsCategories();
@@ -215 +208 @@
         void loadDetailsOptions(DetailsElementType enmType = DetailsElementType_Invalid);
 
-        /** Cleanups context-menu. */
-        void cleanupContextMenu();
-        /** Cleanups root. */
-        void cleanupRoot();
-        /** Cleanups scene. */
-        void cleanupScene();
         /** Cleanups all. */
         void cleanup();