Changeset 106209 in vbox for trunk/src

Timestamp:

Oct 2, 2024 9:05:12 PM (2 months ago)

Author:

vboxsync

Message:

VBoxManage: Fix breakage of "list vms" and "showvminfo" for inaccessible VMs due to misplaced API calls. The inaccessible VM checking must be done first, otherwise just meaningless errors are shown. bugref:10384

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp

@@ -1113 +1113 @@
         pSession->COMGETTER(Console)(pConsole.asOutParam());
 
-    ComPtr<IPlatform> platform;
-    CHECK_ERROR_RET(machine, COMGETTER(Platform)(platform.asOutParam()), hrc);
-    ComPtr<IPlatformProperties> platformProperties;
-    CHECK_ERROR_RET(platform, COMGETTER(Properties)(platformProperties.asOutParam()), hrc);
-
-    PlatformArchitecture_T platformArch;
-    CHECK_ERROR_RET(platform, COMGETTER(Architecture)(&platformArch), hrc);
-
-    ComPtr<IFirmwareSettings> firmwareSettings;
-    CHECK_ERROR_RET(machine, COMGETTER(FirmwareSettings)(firmwareSettings.asOutParam()), hrc);
-
     char szNm[80];
     char szValue[256];
@@ -1185 +1174 @@
         return S_OK;
     }
+
+    ComPtr<IPlatform> platform;
+    CHECK_ERROR_RET(machine, COMGETTER(Platform)(platform.asOutParam()), hrc);
+    ComPtr<IPlatformProperties> platformProperties;
+    CHECK_ERROR_RET(platform, COMGETTER(Properties)(platformProperties.asOutParam()), hrc);
+
+    PlatformArchitecture_T platformArch;
+    CHECK_ERROR_RET(platform, COMGETTER(Architecture)(&platformArch), hrc);
+
+    ComPtr<IFirmwareSettings> firmwareSettings;
+    CHECK_ERROR_RET(machine, COMGETTER(FirmwareSettings)(firmwareSettings.asOutParam()), hrc);
 
     if (details == VMINFO_COMPACT)