Changeset 106221 in vbox for trunk

Timestamp:

Oct 4, 2024 7:51:37 PM (7 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

165005

Message:

3D: Skip SVGA_CMD_BLIT_GRMFB_TO_SCREEN if Src and Dst buffers overlap. bugref:10580

File:

• trunk/src/VBox/Devices/Graphics/DevVGA-SVGA-cmd.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA-cmd.cpp

@@ -8360 +8360 @@
         }
 
+        if (pbDst > pbSrc)
+        {
+            if (pbDst - pbSrc < cbSrcPitch * cHeight)
+            {
+                LogRelMax(4, ("Src buffer 0x%p overlaps Dst buffer 0x%p\n", pbSrc, pbDst));
+                return VERR_INVALID_PARAMETER;
+            }
+        }
+        else if (pbSrc > pbDst)
+        {
+            if (pbSrc - pbDst < cbDstPitch * cHeight)
+            {
+                LogRelMax(4, ("Dst buffer 0x%p overlaps Src buffer 0x%p\n", pbDst, pbSrc));
+                return VERR_INVALID_PARAMETER;
+            }
+        }
+        else
+        {
+            LogRelMax(4, ("Dst and Src buffers are both start at 0x%p\n", pbDst));
+            return VERR_INVALID_PARAMETER;
+        }
+
         if (   cbWidth == (uint32_t)cbGstPitch
             && cbGstPitch == cbHstPitch)