Changeset 106244 in vbox

Timestamp:

Oct 8, 2024 5:08:51 PM (7 weeks ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10513: Advanced Settings Dialog: Accumulate multiple enable-change events into async handler.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings

Files:

• UIAdvancedSettingsDialog.cpp (modified) (4 diffs)
• UIAdvancedSettingsDialog.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp

@@ -790 +790 @@
     , m_fValid(true)
     , m_fSilent(true)
+    , m_pTimerDisabledLookAndFeel(0)
     , m_pLayoutMain(0)
     , m_pCheckBoxMode(0)
@@ -984 +985 @@
     }
 
-    /* Handle enabled-change events: */
-    if (pEvent->type() == QEvent::EnabledChange)
-    {
-        /* Check if watched object is of widget type: */
-        QWidget *pWidget = qobject_cast<QWidget*>(pObject);
-        if (pWidget)
-            adjustLookAndFeelForDisabledWidget(pWidget);
+    /* We'd like to accumulate multiple events of the same type to
+     * process them the bundled way, once after the last one arrived. */
+    switch (pEvent->type())
+    {
+        /* Only enabled-change events useful for us: */
+        case QEvent::EnabledChange:
+        {
+            /* Start (or restart) corresponding timer: */
+            m_pTimerDisabledLookAndFeel->start();
+            break;
+        }
+        default:
+            break;
     }
 
@@ -1051 +1058 @@
     gpDesktop->centerWidget(this, parentWidget(), false);
 
-    /* Make sure widgets disabled initially have font updated: */
-    foreach (QWidget *pChild, findChildren<QWidget*>())
-        if (!pChild->isEnabledTo(0))
-            adjustLookAndFeelForDisabledWidget(pChild);
+    /* Make sure widgets disabled initially have look&feel updated: */
+    sltUpdateDisabledWidgetsLookAndFeel();
 }
 
@@ -1443 +1448 @@
 }
 
+void UIAdvancedSettingsDialog::sltUpdateDisabledWidgetsLookAndFeel()
+{
+    /* Make sure all child widgets have look&feel updated: */
+    foreach (QWidget *pChild, findChildren<QWidget*>())
+        adjustLookAndFeelForDisabledWidget(pChild);
+}
+
 void UIAdvancedSettingsDialog::prepare()
 {
+    /* Create timer to update disabled widgets look&feel: */
+    m_pTimerDisabledLookAndFeel = new QTimer(this);
+    if (m_pTimerDisabledLookAndFeel)
+    {
+        m_pTimerDisabledLookAndFeel->setSingleShot(true);
+        m_pTimerDisabledLookAndFeel->setInterval(50);
+        connect(m_pTimerDisabledLookAndFeel, &QTimer::timeout,
+                this, &UIAdvancedSettingsDialog::sltUpdateDisabledWidgetsLookAndFeel);
+    }
+
     /* Prepare central-widget: */
     setCentralWidget(new QWidget);

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.h

@@ -44 +44 @@
 class QShowEvent;
 class QStackedWidget;
+class QTimer;
 class QIDialogButtonBox;
 class UIFilterEditor;
@@ -213 +214 @@
     void sltHandleVerticalScrollAreaWheelEvent();
 
+    /** Handles request to update disabled widgets look&feel: */
+    void sltUpdateDisabledWidgetsLookAndFeel();
+
 private:
 
@@ -278 +282 @@
     QMap<int, QString>  m_pageHelpKeywords;
 
+    /** Holds the timer to update disabled widgets look&feel. */
+    QTimer *m_pTimerDisabledLookAndFeel;
+
     /** @name Widgets
      * @{ */