Changeset 106268 in vbox for trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-instr-4.c32

Timestamp:

Oct 10, 2024 3:42:50 AM (7 weeks ago)

Author:

vboxsync

Message:

ValidationKit/bootsectors: clean up mask twiddling scheme; bugref:10658

File:

• trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-instr-4.c32 (modified) (6 diffs)

trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-instr-4.c32

@@ -2566 +2566 @@
     uint32_t uSpecifiedMask, uExpectedMask, uImpliedMask, uCombinedMask, uMaskedMask, uUnmaskedMask, uThisMask;
     uint32_t uExpectedMxCsr_orig, uExpectedExceptions, uExpectedUnmaskedExceptions, uInitialExceptions, uRandTmp;
+    uint64_t uSeenMasks = 0;
     bool fFuzzyPE;
     uint32_t uForceOnMask, uForceOffMask;
-    const char *pszMaskType;
+    static const char * const s_apszMaskType[] = { "Specified", "Expected", "Implied", "Combined", "Masked", "Unmasked", "Random" };
     unsigned iMaskType;
     static bool      sfMismatchShown     = false;
@@ -2646 +2647 @@
     uImpliedMask = (uExpectedMxCsr_orig & X86_MXCSR_XCPT_FLAGS) << X86_MXCSR_XCPT_MASK_SHIFT;
     uCombinedMask = uSpecifiedMask | uImpliedMask;
-    uMaskedMask = X86_MXCSR_XCPT_MASK & ~uForceOffMask;
-    uUnmaskedMask = 0 | uForceOnMask;
+    uMaskedMask = X86_MXCSR_XCPT_MASK;
+    uUnmaskedMask = 0;
 
    for (iMaskType = 0; iMaskType <= 6; iMaskType++)
@@ -2658 +2659 @@
         case 0:
             uThisMask = uSpecifiedMask;
-            pszMaskType = "Specified";
             break;
         case 1:
-            if (uExpectedMask == uSpecifiedMask) continue;
             uThisMask = uExpectedMask;
-            pszMaskType = "Expected";
             break;
         case 2:
-            if (uImpliedMask == uSpecifiedMask || uImpliedMask == uExpectedMask) continue;
             uThisMask = uImpliedMask;
-            pszMaskType = "Implied";
             break;
         case 3:
-            if (uCombinedMask == uSpecifiedMask || uCombinedMask == uExpectedMask || uCombinedMask == uImpliedMask) continue;
             uThisMask = uCombinedMask;
-            pszMaskType = "Combined";
             break;
         case 4:
-            if (uMaskedMask == uSpecifiedMask || uMaskedMask == uExpectedMask || uMaskedMask == uImpliedMask || uMaskedMask == uCombinedMask) continue;
             uThisMask = uMaskedMask;
-            pszMaskType = "Masked";
             break;
         case 5:
-            if (uUnmaskedMask == uSpecifiedMask || uUnmaskedMask == uExpectedMask || uUnmaskedMask == uImpliedMask || uUnmaskedMask == uCombinedMask) continue;
             uThisMask = uUnmaskedMask;
-            pszMaskType = "Unmasked";
             break;
         case 6:
+            /* This case must be last, as it trashes uSeenMasks & uInitialExceptions */
             uRandTmp = bs3CpuInstrX_SimpleRand();
             switch (uRandTmp & X86_MXCSR_RC_MASK)
@@ -2696 +2687 @@
                     uThisMask = uSpecifiedMask;
                     uInitialExceptions = uRandTmp & X86_MXCSR_XCPT_FLAGS;
+                    uSeenMasks = 0;         /* Don't skip for same-mask */
                     break;
                 case X86_MXCSR_RC_DOWN:     /* Random mask & initial exceptions */
                     uThisMask = uRandTmp & X86_MXCSR_XCPT_MASK;
                     uInitialExceptions = uRandTmp & X86_MXCSR_XCPT_FLAGS;
+                    uSeenMasks = 0;         /* Don't skip for same-mask */
                     break;
                 default:
                     BS3_ASSERT(0);
             }
-            pszMaskType = "Random";
             break;
         default:
@@ -2711 +2703 @@
     /* No matter what was chosen, honor FIXED mask bits */
     uThisMask = (uThisMask | uForceOnMask) & ~uForceOffMask;
+
+    /* Skip millions of redundant tests imposed by the mask twiddling scheme */
+    if (uSeenMasks & (RT_BIT_64(uThisMask >> X86_MXCSR_XCPT_MASK_SHIFT))) continue;
+    uSeenMasks |= RT_BIT_64(uThisMask >> X86_MXCSR_XCPT_MASK_SHIFT);
 
     /* This is the input MXCSR value we'll be sending */
@@ -2895 +2891 @@
 
     if (cErrors != Bs3TestSubErrorCount())
-        Bs3TestFailedF("Mask mode %s, mask=%#RX32, in-exceptions=%#RX32, in-MxCsr=%#RX32, expect-MxCsr=%#RX32", pszMaskType, uThisMask, uInitialExceptions, uMxCsr, uExpectedMxCsr);
+        Bs3TestFailedF("Mask mode %s, mask=%#RX32, in-exceptions=%#RX32, in-MxCsr=%#RX32, expect-MxCsr=%#RX32", s_apszMaskType[iMaskType], uThisMask, uInitialExceptions, uMxCsr, uExpectedMxCsr);
    }