Changeset 106312 in vbox for trunk

Timestamp:

Oct 14, 2024 4:38:55 PM (7 weeks ago)

Author:

vboxsync

Message:

FE/Qt: Runtime UI: Do not show mouse related errors, as it's free to discard our put-mouse-event requests; Previously this could cause multiple error-messages the moment we are switching from relative to absolute mode.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• notificationcenter/UINotificationObjects.cpp (modified) (1 diff)
• notificationcenter/UINotificationObjects.h (modified) (1 diff)
• runtime/UISession.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.cpp

@@ -1122 +1122 @@
         QApplication::translate("UIMessageCenter", "Failed to change keyboard parameter.") +
         UIErrorString::formatErrorInfo(comKeyboard));
-}
-
-/* static */
-void UINotificationMessage::cannotChangeMouseParameter(const CMouse &comMouse)
-{
-    createMessage(
-        QApplication::translate("UIMessageCenter", "Mouse failure ..."),
-        QApplication::translate("UIMessageCenter", "Failed to change mouse parameter.") +
-        UIErrorString::formatErrorInfo(comMouse));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.h

@@ -452 +452 @@
           * @param  comKeyboard  Brings the object parameter being changed for. */
         static void cannotChangeKeyboardParameter(const CKeyboard &comKeyboard);
-        /** Notifies about inability to change IMouse parameter.
-          * @param  comMouse  Brings the object parameter being changed for. */
-        static void cannotChangeMouseParameter(const CMouse &comMouse);
         /** Notifies about inability to change IVirtualSystemDescription parameter.
           * @param  comVsd  Brings the object parameter being changed for. */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp

@@ -587 +587 @@
         return false;
     comMouse.PutMouseEvent(iDx, iDy, iDz, iDw, iButtonState);
-    const bool fSuccess = comMouse.isOk();
-    if (!fSuccess)
-        UINotificationMessage::cannotChangeMouseParameter(comMouse);
-    return fSuccess;
+    return comMouse.isOk();
 }
 
@@ -599 +596 @@
         return false;
     comMouse.PutMouseEventAbsolute(iX, iY, iDz, iDw, iButtonState);
-    const bool fSuccess = comMouse.isOk();
-    if (!fSuccess)
-        UINotificationMessage::cannotChangeMouseParameter(comMouse);
-    return fSuccess;
+    return comMouse.isOk();
 }
 
@@ -611 +605 @@
         return false;
     comMouse.PutEventMultiTouch(iCount, contacts, fIsTouchScreen, uScanTime);
-    const bool fSuccess = comMouse.isOk();
-    if (!fSuccess)
-        UINotificationMessage::cannotChangeMouseParameter(comMouse);
-    return fSuccess;
+    return comMouse.isOk();
 }