Network

Timestamp:

Feb 26, 2007 4:11:53 PM (18 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

18941

Message:

forward port of the TAPWin32 destruct fix

File:

trunk/src/VBox/Devices/Network/DrvTAPWin32.cpp

-              r645
+              r1064
 #ifdef ASYNC_NETIO
+    /* Ensure that it does not spin in the CanReceive loop */
+    /** @todo this isn't a safe method to notify the async thread; it might be using the instance
+     *        data after we've been destroyed; could wait for it to terminate, but that's not
+     *        without risks either.
+     */
+    SetEvent(pData->hHaltAsyncEventSem);
+    /* Ensure that it does not spin in the CanReceive loop. Do it _after_ we set set the
+     * hHaltAsyncEventSem to ensure that we don't go into the loop again immediately. */
     if (ASMAtomicXchgU32(&pData->fOutOfSpace, false))
         RTSemEventSignal(pData->EventOutOfSpace);
-    /* @todo this isn't a safe method to notify the async thread; it might be using the instance data after we've been
-     *       destroyed; could wait for it to terminate, but that's not without risks either.
-     */
-    SetEvent(pData->hHaltAsyncEventSem);
     /* Yield or else our async thread will never acquire the event semaphore */

Note: See TracChangeset for help on using the changeset viewer.