Changeset 106568 in vbox for trunk/src

Timestamp:

Oct 21, 2024 3:09:22 PM (6 weeks ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10767: VM settings / Display page: Cleanup for VRAM editor; No need to cache min VRAM size as it will be dynamical depending on graphics controller and 3D support.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors

Files:

• UIVideoMemoryEditor.cpp (modified) (5 diffs)
• UIVideoMemoryEditor.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVideoMemoryEditor.cpp

@@ -52 +52 @@
     , m_f3DAccelerationEnabled(false)
 #endif
-    , m_iMinVRAM(0)
     , m_iMaxVRAM(0)
     , m_pLayout(0)
@@ -183 +182 @@
     if (m_pLabelMemoryMin)
     {
-        m_pLabelMemoryMin->setText(tr("%1 MB").arg(m_iMinVRAM));
         m_pLabelMemoryMin->setToolTip(tr("Minimum possible video memory size."));
     }
@@ -225 +223 @@
     /* Prepare common variables: */
     const CSystemProperties comProperties = gpGlobalSession->virtualBox().GetSystemProperties();
-    m_iMinVRAM = comProperties.GetMinGuestVRAM();
     m_iMaxVRAM = comProperties.GetMaxGuestVRAM();
 
@@ -252 +249 @@
             if (m_pSlider)
             {
-                m_pSlider->setMinimum(m_iMinVRAM);
+                m_pSlider->setMinimum(0);
                 m_pSlider->setMaximum(m_iMaxVRAM);
                 m_pSlider->setPageStep(calculatePageStep(m_iMaxVRAM));
@@ -299 +296 @@
             if (m_pLabelMemory)
                 m_pLabelMemory->setBuddy(m_pSpinBox);
-            m_pSpinBox->setMinimum(m_iMinVRAM);
+            m_pSpinBox->setMinimum(0);
             m_pSpinBox->setMaximum(m_iMaxVRAM);
             connect(m_pSpinBox, &QSpinBox::valueChanged,

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVideoMemoryEditor.h

@@ -114 +114 @@
      * @{ */
         /** Holds the guest OS type Id. */
-        QString                 m_strGuestOSTypeId;
+        QString                  m_strGuestOSTypeId;
         /** Holds the guest screen count. */
         int                      m_cGuestScreenCount;
@@ -126 +126 @@
 #endif
 
-        /** Holds the minimum lower limit of VRAM (MiB). */
-        int  m_iMinVRAM;
         /** Holds the maximum upper limit of VRAM (MiB). */
         int  m_iMaxVRAM;