Changeset 106599 in vbox

Timestamp:

Oct 23, 2024 12:54:21 AM (5 weeks ago)

Author:

vboxsync

Message:

DevPlatform: Warnings. jiraref:VBP-1171

File:

• trunk/src/VBox/Devices/Misc/DevPlatform.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Misc/DevPlatform.cpp

@@ -263 +263 @@
         {
             if (!pIt->fResourceId)
-                RTFileReadAllFree(pIt->pu8ResourceFree, (size_t)pIt->cbResource);
+                RTFileReadAllFree(pIt->pu8ResourceFree, pIt->cbResource);
             else
                 PDMDevHlpMMHeapFree(pDevIns, pIt->pu8ResourceFree);
@@ -307 +307 @@
     RTListForEach(&pThis->LstResourcesMem, pIt, DEVPLATFORMRESOURCE, NdLst)
     {
-        int rc = platformR3ResourceResolveContent(pDevIns, pThis, pIt, (void **)&pIt->pu8ResourceFree, (const void **)&pIt->pu8Resource, &pIt->cbResource);
+        int rc = platformR3ResourceResolveContent(pDevIns, pThis, pIt, (void **)&pIt->pu8ResourceFree,
+                                                  (const void **)&pIt->pu8Resource, &pIt->cbResource);
         if (RT_SUCCESS(rc))
         {
@@ -316 +317 @@
             {
                 if (!pIt->fResourceId)
-                    RTFileReadAllFree(pIt->pu8ResourceFree, (size_t)pIt->cbResource);
+                    RTFileReadAllFree(pIt->pu8ResourceFree, pIt->cbResource);
                 else
                     PDMDevHlpMMHeapFree(pDevIns, pIt->pu8ResourceFree);
@@ -379 +380 @@
     RTListForEach(&pThis->LstResourcesRom, pIt, DEVPLATFORMRESOURCE, NdLst)
     {
-        rc = platformR3ResourceResolveContent(pDevIns, pThis, pIt, (void **)&pIt->pu8ResourceFree, (void const **)&pIt->pu8Resource, &pIt->cbResource);
+        rc = platformR3ResourceResolveContent(pDevIns, pThis, pIt, (void **)&pIt->pu8ResourceFree,
+                                              (void const **)&pIt->pu8Resource, &pIt->cbResource);
         if (RT_SUCCESS(rc))
-            rc = PDMDevHlpROMRegister(pDevIns, platformR3ResourceGetLoadAddress(pDevIns, pIt), pIt->cbResource, pIt->pu8Resource, pIt->cbResource,
+        {
+            AssertLogRel((uint32_t)pIt->cbResource == pIt->cbResource);
+            rc = PDMDevHlpROMRegister(pDevIns, platformR3ResourceGetLoadAddress(pDevIns, pIt),
+                                      (uint32_t)pIt->cbResource, pIt->pu8Resource, (uint32_t)pIt->cbResource,
                                       PGMPHYS_ROM_FLAGS_SHADOWED | PGMPHYS_ROM_FLAGS_PERMANENT_BINARY, pIt->szName);
+        }
         AssertRCReturn(rc, rc);
     }