Changeset 106600 in vbox

Timestamp:

Oct 23, 2024 12:54:42 AM (5 weeks ago)

Author:

vboxsync

Message:

DevPL061: Warnings. jiraref:VBP-1171

File:

• trunk/src/VBox/Devices/Gpio/DevPL061.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Gpio/DevPL061.cpp

@@ -255 +255 @@
      *     to be read as 0, regardless of their value.
      */
-    if (    off >= PL061_REG_GPIODATA_INDEX
-        &&  off < PL061_REG_GPIODATA_INDEX_END + sizeof(uint32_t))
+    AssertCompile(PL061_REG_GPIODATA_INDEX == 0); /* Skip 'off >= PL061_REG_GPIODATA_INDEX' check and avoid C4267 */
+    if (off < PL061_REG_GPIODATA_INDEX_END + sizeof(uint32_t))
     {
         *(uint32_t *)pv = pThis->u8RegData & (uint8_t)(off >> 2);
@@ -343 +343 @@
      *     must be HIGH. Otherwise the bit values remain unchanged by the write.
      */
-    if (    off >= PL061_REG_GPIODATA_INDEX
-        &&  off < PL061_REG_GPIODATA_INDEX_END + sizeof(uint32_t))
+    AssertCompile(PL061_REG_GPIODATA_INDEX == 0); /* Skip 'off >= PL061_REG_GPIODATA_INDEX' check and avoid C4267 */
+    if (off < PL061_REG_GPIODATA_INDEX_END + sizeof(uint32_t))
     {
         uint8_t uMask = (uint8_t)(off >> 2);
@@ -459 +459 @@
     PDEVPL061   pThis   = PDMDEVINS_2_DATA(pDevIns, PDEVPL061);
 
-    AssertReturn(idGpio < PL061_GPIO_NUM, VERR_INVALID_PARAMETER);
-
-    return !RT_BOOL(pThis->u8RegDir & RT_BIT(idGpio)); /* Bit cleared means input. */
+    AssertReturn(idGpio < PL061_GPIO_NUM, false);
+
+    return !(pThis->u8RegDir & RT_BIT(idGpio)); /* Bit cleared means input. */
 }