Changeset 106680 in vbox for trunk/src/VBox/Disassembler

Timestamp:

Oct 25, 2024 9:18:06 AM (6 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

165550

Message:

Disasembler: Decode extr instruction, bugref:10394

Location:

trunk/src/VBox/Disassembler

Files:

• DisasmTables-armv8-a64.cpp (modified) (2 diffs)
• testcase/tstDisasmArmv8-1-asm.S (modified) (1 diff)

trunk/src/VBox/Disassembler/DisasmTables-armv8-a64.cpp

@@ -163 +163 @@
 
 
+/* SBFM/BFM/UBFM */
+DIS_ARMV8_DECODE_INSN_CLASS_DEFINE_DECODER(Extract) /** @todo N must match SF, and for sf == 0 -> imms<5> == 0. */
+    DIS_ARMV8_INSN_DECODE(kDisParmParseSf,            31,  1, DIS_ARMV8_INSN_PARAM_UNSET),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseGprZr,          0,  5, 0 /*idxParam*/),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseGprZr,          5,  5, 1 /*idxParam*/),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseGprZr,         16,  5, 2 /*idxParam*/),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseImm,           10,  6, 3 /*idxParam*/),
+DIS_ARMV8_DECODE_INSN_CLASS_DEFINE_BEGIN(Extract)
+    DIS_ARMV8_OP(0x13800000, "extr",            OP_ARMV8_A64_EXTR,      DISOPTYPE_HARMLESS),
+DIS_ARMV8_DECODE_INSN_CLASS_DEFINE_END(Extract, 0x7fa00000 /*fFixedInsn*/,
+                                       kDisArmV8OpcDecodeNop, 0, 0);
+
+
 /*
  * C4.1.65 of the ARMv8 architecture reference manual has the following table for the
@@ -185 +198 @@
     DIS_ARMV8_DECODE_MAP_ENTRY(MoveWide),
     DIS_ARMV8_DECODE_MAP_ENTRY(Bitfield),
-    DIS_ARMV8_DECODE_MAP_INVALID_ENTRY                  /** @todo Extract */
+    DIS_ARMV8_DECODE_MAP_ENTRY(Extract)
 DIS_ARMV8_DECODE_MAP_DEFINE_END(DataProcessingImm, RT_BIT_32(23) | RT_BIT_32(24) | RT_BIT_32(25),  23);
 

trunk/src/VBox/Disassembler/testcase/tstDisasmArmv8-1-asm.S

@@ -497 +497 @@
         bics xzr, xzr, xzr, ROR #63
 
+        extr wzr, w0, w1, #0
+        extr wzr, w0, w1, #31
+
+        extr xzr, x0, x1, #0
+        extr xzr, x0, x1, #63
+
         ; Memory loads
         ldrb w0, [x28]