Changeset 106705 in vbox for trunk/src/VBox/Disassembler

Timestamp:

Oct 25, 2024 3:08:49 PM (6 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

165578

Message:

Disassembler: Decode conditional select instructions, bugref:10394

Location:

trunk/src/VBox/Disassembler

Files:

• DisasmTables-armv8-a64.cpp (modified) (2 diffs)
• testcase/tstDisasmArmv8-1-asm.S (modified) (1 diff)

trunk/src/VBox/Disassembler/DisasmTables-armv8-a64.cpp

@@ -786 +786 @@
 
 
+/* CSEL/CSINC/CSINV/CSNEG */
+DIS_ARMV8_DECODE_INSN_CLASS_DEFINE_DECODER(CondSel)
+    DIS_ARMV8_INSN_DECODE(kDisParmParseSf,            31,  1, DIS_ARMV8_INSN_PARAM_UNSET),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseGprZr,          0,  5, 0 /*idxParam*/),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseGprZr,          5,  5, 1 /*idxParam*/),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseGprZr,         16,  5, 2 /*idxParam*/),
+    DIS_ARMV8_INSN_DECODE(kDisParmParseCond,          12,  4, 3 /*idxParam*/),
+DIS_ARMV8_DECODE_INSN_CLASS_DEFINE_BEGIN(CondSel)
+    DIS_ARMV8_OP(0x1a800000, "csel",            OP_ARMV8_A64_CSEL,      DISOPTYPE_HARMLESS),
+    DIS_ARMV8_OP(0x1a800400, "csinc",           OP_ARMV8_A64_CSINC,     DISOPTYPE_HARMLESS),
+    INVALID_OPCODE,
+    INVALID_OPCODE,
+    DIS_ARMV8_OP(0x5a800000, "csinv",           OP_ARMV8_A64_CSINC,     DISOPTYPE_HARMLESS),
+    DIS_ARMV8_OP(0x5a800400, "csneg",           OP_ARMV8_A64_CSNEG,     DISOPTYPE_HARMLESS)
+DIS_ARMV8_DECODE_INSN_CLASS_DEFINE_END(CondSel, 0x7fe00c00 /*fFixedInsn*/, kDisArmV8OpcDecodeCollate,
+                                       RT_BIT_32(10) | RT_BIT_32(11) | RT_BIT_32(30), 10);
+
+
 /*
  * C4.1.95 - Data Processing - Register
@@ -809 +827 @@
     DIS_ARMV8_DECODE_MAP_ENTRY(CondCmp),
     DIS_ARMV8_DECODE_MAP_INVALID_ENTRY,
-    DIS_ARMV8_DECODE_MAP_INVALID_ENTRY,             /** @todo Conditional select. */
+    DIS_ARMV8_DECODE_MAP_ENTRY(CondSel),
     DIS_ARMV8_DECODE_MAP_INVALID_ENTRY,
     DIS_ARMV8_DECODE_MAP_ENTRY(Reg2Src1Src),

trunk/src/VBox/Disassembler/testcase/tstDisasmArmv8-1-asm.S

@@ -503 +503 @@
         extr xzr, x0, x1, #63
 
+        csel xzr, x1, x2, eq
+        csel wzr, w1, w2, eq
+
+        csinc xzr, x1, x2, eq
+        csinc wzr, w1, w2, eq
+
+        csinv xzr, x1, x2, eq
+        csinv wzr, w1, w2, eq
+
+        csneg xzr, x1, x2, eq
+        csneg wzr, w1, w2, eq
+
         ; Memory loads
         ldrb w0, [x28]