Changeset 106707 in vbox for trunk/src/VBox/Frontends

Timestamp:

Oct 25, 2024 4:18:51 PM (3 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10793. A better handling of UpdateState enum values in UINotificationProgressNewVersionChecker.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.cpp

@@ -4659 +4659 @@
         return;
 
-    bool const fUpdateAvailable = m_comUpdateHost.GetState() == KUpdateState_Available; /** @todo Handle other states. */
+    KUpdateState enmState = m_comUpdateHost.GetState();
     if (!m_comUpdateHost.isOk())
         return;
 
-    if (fUpdateAvailable)
-    {
-        QString strVersion = m_comUpdateHost.GetVersion();
-        if (!m_comUpdateHost.isOk())
-            return;
-
-        QString strURL = m_comUpdateHost.GetDownloadUrl();
-        if (!m_comUpdateHost.isOk())
-            return;
-
-        UINotificationMessage::showUpdateSuccess(strVersion, strURL);
-    }
-    else
-    {
-        if (m_fForcedCall)
-            UINotificationMessage::showUpdateNotFound();
-    }
+    switch (enmState)
+    {
+        case KUpdateState_Available:
+        {
+            QString strVersion = m_comUpdateHost.GetVersion();
+            if (!m_comUpdateHost.isOk())
+                return;
+            QString strURL = m_comUpdateHost.GetDownloadUrl();
+            if (!m_comUpdateHost.isOk())
+                return;
+            UINotificationMessage::showUpdateSuccess(strVersion, strURL);
+            break;
+        }
+        case KUpdateState_NotAvailable:
+        {
+            if (m_fForcedCall)
+                UINotificationMessage::showUpdateNotFound();
+            break;
+        }
+        case KUpdateState_Invalid:
+        case KUpdateState_Error:
+        case KUpdateState_Max:
+            /* Error cases are handled not here: */
+            break;
+        case KUpdateState_Downloading:
+        case KUpdateState_Downloaded:
+        case KUpdateState_Installing:
+        case KUpdateState_Installed:
+        case KUpdateState_UserInteraction:
+        case KUpdateState_Canceled:
+        case KUpdateState_Maintenance:
+            /* These cases are not yet implemented in Main: */
+            break;
+        default:
+            break;
+    }
+
 #endif /* VBOX_WITH_UPDATE_AGENT */
 }