Changeset 106822 in vbox

Timestamp:

Nov 4, 2024 6:41:18 PM (3 months ago)

Author:

vboxsync

Message:

Windows host installer/InstallHelper: Don't ignore (at least for now) the overall outcome of an (un)installation and report an error back to the installer if failed. bugref:10762

File:

• trunk/src/VBox/Installer/win/InstallHelper/VBoxInstallHelper.cpp (modified) (2 diffs)

trunk/src/VBox/Installer/win/InstallHelper/VBoxInstallHelper.cpp

@@ -1514 +1514 @@
     }
 
-    logStringF(hModule, "DriverInstall: Handling done. rc=%Rrc (ignored)", rc);
-    return ERROR_SUCCESS; /* Do not fail here. */
+    logStringF(hModule, "DriverInstall: Handling done (rc=%Rrc)", rc);
+    return RT_SUCCESS(rc) ? ERROR_SUCCESS : ERROR_DRIVER_INSTALL_BLOCKED /* Close enough */;
 }
 
@@ -1567 +1567 @@
     }
 
-    logStringF(hModule, "DriverUninstall: Handling done. rc=%Rrc (ignored)", rc);
-    return ERROR_SUCCESS; /* Do not fail here. */
+    logStringF(hModule, "DriverUninstall: Handling done (rc=%Rrc)", rc);
+    return RT_SUCCESS(rc) ? ERROR_SUCCESS : ERROR_DRIVER_STORE_DELETE_FAILED /* Close enough */;
 }