Changeset 106963 in vbox for trunk

Timestamp:

Nov 12, 2024 2:58:12 PM (6 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

165893

Message:

Windows driver installation/VBoxDrvInst: Refuse to run on <= NT4. Logging adjustments. bugref:10762

File:

• trunk/src/VBox/GuestHost/installation/VBoxDrvInst.cpp (modified) (8 diffs)

trunk/src/VBox/GuestHost/installation/VBoxDrvInst.cpp

@@ -238 +238 @@
  *
  * @returns VBox status code.
- * @param
+ * @param   pszPrefix           Logging prefix to use. Can be NULL.
  * @param   pszFormat           Format string to log.
  * @param   args                va_list to use.
  */
-DECLINLINE(void) vboxDrvInstLogExV(const char *pszFormat, va_list args)
+DECLINLINE(void) vboxDrvInstLogExV(const char *pszPrefix, const char *pszFormat, va_list args)
 {
     char *psz = NULL;
@@ -248 +248 @@
     AssertPtrReturnVoid(psz);
 
-    LogRel(("%s", psz));
+    if (pszPrefix)
+        LogRel(("%s: %s", pszPrefix, psz));
+    else
+        LogRel(("%s", psz));
 
     RTStrFree(psz);
@@ -263 +266 @@
     va_list args;
     va_start(args, pszFormat);
-    vboxDrvInstLogExV(pszFormat, args);
+    vboxDrvInstLogExV("*** Error", pszFormat, args);
     va_end(args);
 }
@@ -277 +280 @@
     va_list args;
     va_start(args, pszFormat);
-    vboxDrvInstLogExV(pszFormat, args);
+    vboxDrvInstLogExV(NULL, pszFormat, args);
     va_end(args);
 }
@@ -294 +297 @@
     {
         case VBOXWINDRIVERLOGTYPE_ERROR:
-            vboxDrvInstLogError("*** Error: %s\n", pszMsg);
+            vboxDrvInstLogError("%s\n", pszMsg);
             break;
 
@@ -838 +841 @@
     }
 
+    /* Refuse to run on too old Windows versions (<= NT4). */
+    uint64_t const uNtVer = RTSystemGetNtVersion();
+    if (RTSYSTEM_NT_VERSION_GET_MAJOR(uNtVer) <= 4)
+    {
+        vboxDrvInstLogError("Windows version (%d.%d.%d) too old and not supported\n", RTSYSTEM_NT_VERSION_GET_MAJOR(uNtVer),
+                                                                                      RTSYSTEM_NT_VERSION_GET_MINOR(uNtVer),
+                                                                                      RTSYSTEM_NT_VERSION_GET_BUILD(uNtVer));
+        return VERR_NOT_SUPPORTED;
+    }
+
     return VINF_SUCCESS;
 }
@@ -903 +916 @@
                         rc = vboxDrvInstInit();
                         if (RT_FAILURE(rc))
-                            return  RTEXITCODE_FAILURE;
+                            return RTEXITCODE_FAILURE;
 
                         /* Count the combined option definitions:  */
@@ -951 +964 @@
     rc = vboxDrvInstInit();
     if (RT_FAILURE(rc))
-        return  RTEXITCODE_FAILURE;
+        return RTEXITCODE_FAILURE;
     RTEXITCODE rcExit = vboxDrvInstCmdListMain(&GetState);
     vboxDrvInstDestroy();