Changeset 106995 in vbox for trunk

Timestamp:

Nov 13, 2024 4:51:17 PM (2 weeks ago)

Author:

vboxsync

Message:

Additions/VBoxTray: Give a better clue to the user when VBoxTray is unable to start if unable to open a connection to the VBoxGuest driver. Addendum fix: Only show in verbose mode.

File:

• trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxTray.cpp (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxTray.cpp

@@ -1266 +1266 @@
     else
     {
-        if (rc == VERR_OPEN_FAILED)
-            VBoxTrayShowError("Error opening a connection to the VBoxGuest.sys driver.\n\n"
-                              "This might be due to not having the Windows Guest Additions installed\n"
-                              "or that something went wrong when installing those.\n\n"
-                              "Re-installing the Guest Additions might resolve the issue.\n");
-        else
-            VBoxTrayShowError("VbglR3Init failed: %Rrc\n", rc);
+        /* Only show something if started in verbose mode.
+         * Otherwise just fail silently as we ever did. Needed in order to not break installs on non-VMs. */
+        if (g_cVerbosity)
+        {
+            if (rc == VERR_OPEN_FAILED)
+                VBoxTrayShowError("Error opening a connection to the VBoxGuest.sys driver.\n\n"
+                                  "This might be due to not having the Windows Guest Additions installed\n"
+                                  "or that something went wrong when installing those.\n\n"
+                                  "Re-installing the Guest Additions might resolve the issue.\n");
+            else
+                VBoxTrayShowError("VbglR3Init failed: %Rrc\n", rc);
+        }
     }