Changeset 107011 in vbox

Timestamp:

Nov 15, 2024 8:39:44 AM (2 months ago)

Author:

vboxsync

Message:

Disassembler/DisasmCore-armv8: Implemented stub for parsing CRnCRm to avoid crashing here on Win11/Arm. Added some assertions to better catch unhandled stuff.

File:

• trunk/src/VBox/Disassembler/DisasmCore-armv8.cpp (modified) (4 diffs)

trunk/src/VBox/Disassembler/DisasmCore-armv8.cpp

@@ -92 +92 @@
 static FNDISPARSEARMV8 disArmV8ParseCond;
 static FNDISPARSEARMV8 disArmV8ParsePState;
+static FNDISPARSEARMV8 disArmV8ParseCRnCRm;
 static FNDISPARSEARMV8 disArmV8ParseSysReg;
 static FNDISPARSEARMV8 disArmV8ParseSh12;
@@ -159 +160 @@
     disArmV8ParseCond,
     disArmV8ParsePState,
-    NULL,
+    disArmV8ParseCRnCRm,
     disArmV8ParseSysReg,
     disArmV8ParseSh12,
@@ -590 +591 @@
 
 
+static int disArmV8ParseCRnCRm(PDISSTATE pDis, uint32_t u32Insn, PCDISARMV8OPCODE pOp, PCDISARMV8INSNCLASS pInsnClass, PDISOPPARAM pParam, PCDISARMV8INSNPARAM pInsnParm, bool *pf64Bit)
+{
+    RT_NOREF(pDis, u32Insn, pOp, pInsnClass, pParam, pInsnParm, pf64Bit);
+
+    Assert(pInsnParm->cBits == 8);
+
+    /** @todo Needs implementation. */
+    return VERR_DIS_INVALID_OPCODE;
+}
+
+
 static int disArmV8ParseSysReg(PDISSTATE pDis, uint32_t u32Insn, PCDISARMV8OPCODE pOp, PCDISARMV8INSNCLASS pInsnClass, PDISOPPARAM pParam, PCDISARMV8INSNPARAM pInsnParm, bool *pf64Bit)
 {
@@ -1346 +1358 @@
            && RT_SUCCESS(rc))
     {
+        Assert(pDecode->idxParse < kDisParmParseMax);
+        Assert(g_apfnDisasm[pDecode->idxParse]);
         rc = g_apfnDisasm[pDecode->idxParse](pDis, u32Insn, pOp, pInsnClass,
                                                pDecode->idxParam != DIS_ARMV8_INSN_PARAM_UNSET