Changeset 107012 in vbox for trunk

Timestamp:

Nov 15, 2024 9:35:45 AM (2 weeks ago)

Author:

vboxsync

Message:

Main/cbinding/tstCAPIGlue: Don't run interactively (i.e. by requiring user input) by default. This will cause timeouts on the testboxes if we forgot to blacklist testcases for whatever reason.

File:

• trunk/src/VBox/Main/cbinding/tstCAPIGlue.c (modified) (3 diffs)

trunk/src/VBox/Main/cbinding/tstCAPIGlue.c

@@ -846 +846 @@
  * List the registered VMs.
  *
- * @param   argv0       executable name
+ * @param   argc        number of arguments
+ * @param   argv        argument vector
  * @param   virtualBox  ptr to IVirtualBox object
  * @param   session     ptr to ISession object
  */
-static void listVMs(const char *argv0, IVirtualBox *virtualBox, ISession *session)
-{
+static void listVMs(int argc, char **argv, IVirtualBox *virtualBox, ISession *session)
+{
+    const char *argv0 = argv[0];
+
     HRESULT hrc;
     SAFEARRAY *machinesSA = g_pVBoxFuncs->pfnSafeArrayOutParamAlloc();
@@ -970 +973 @@
     /*
      * Let the user chose a machine to start.
+     *
+     * Note! Testcases need to run without interaction required by default,
+     *       so only do this if manually specifying the 'start' command.
      */
-    printf("Type Machine# to start (0 - %u) or 'quit' to do nothing: ",
-           (unsigned)(machineCnt - 1));
-    fflush(stdout);
-
-    if (scanf("%u", &start_id) == 1 && start_id < machineCnt)
-    {
-        IMachine *machine = machines[start_id];
-
-        if (machine)
+    if (    argc >= 2
+        && !stricmp(argv[1], "start"))
+    {
+        printf("Type Machine# to start (0 - %u) or 'quit' to do nothing: ",
+               (unsigned)(machineCnt - 1));
+        fflush(stdout);
+
+        if (scanf("%u", &start_id) == 1 && start_id < machineCnt)
         {
-            BSTR uuidUtf16 = NULL;
-
-            IMachine_get_Id(machine, &uuidUtf16);
-            startVM(argv0, virtualBox, session, uuidUtf16);
-            g_pVBoxFuncs->pfnComUnallocString(uuidUtf16);
+            IMachine *machine = machines[start_id];
+
+            if (machine)
+            {
+                BSTR uuidUtf16 = NULL;
+
+                IMachine_get_Id(machine, &uuidUtf16);
+                startVM(argv0, virtualBox, session, uuidUtf16);
+                g_pVBoxFuncs->pfnComUnallocString(uuidUtf16);
+            }
         }
     }
+    else
+        printf("Note: Use 'start' to start a VM when running interactively.\n\n");
 
     /*
@@ -1103 +1115 @@
         PrintErrorInfo(argv[0], "GetHomeFolder() failed", hrc);
 
-    listVMs(argv[0], vbox, session);
+    listVMs(argc, argv, vbox, session);
     ISession_UnlockMachine(session);